From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37569 invoked by alias); 27 Oct 2017 21:11:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37458 invoked by uid 89); 27 Oct 2017 21:11:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:EUR02-A, Hx-spam-relays-external:sk:EUR02-A, H*RU:sk:EUR02-A, HTo:D*mathworks.com X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Oct 2017 21:11:04 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 76.C6.03220.5E0A3F95; Fri, 27 Oct 2017 23:11:01 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 27 Oct 2017 23:11:01 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.28] (192.75.88.130) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.3; Fri, 27 Oct 2017 21:10:59 +0000 Subject: Re: [RFC][PATCH] fix gdb segv when objfile can't be opened To: Mike Gulick , Simon Marchi CC: References: <59E8B251.4050100@mathworks.com> <8c08307a-94ad-92b8-9c8b-c713cad541fd@mathworks.com> <56b1cb34b33613ca4496abfcd28f135a@polymtl.ca> From: Simon Marchi Message-ID: Date: Fri, 27 Oct 2017 21:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR2201CA0049.namprd22.prod.outlook.com (2603:10b6:301:16::23) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 984d6a78-b18f-412e-46c0-08d51d7f3944 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;3:MbmpdERrKDPFhvJl+HtMwHOPaDfHFHdmMnJ8XeW3wLT9aEd+DBc1Z6F7zDhpKLc4BxkW2by6idan3VnZKaGaJFAT2IyFxaY7uqS9/Ed1MBsH+0tYkeDztctRR80o8LfFAt9QrtQlEhZvVcuQscqRpGIhLtc2x1KBiT38j4/opJXD36YfA6K06CgqdvphsHcV5ogN/H2q4F8B4ff/bEXTV8QGPt5NKAeeEpilv+HyyB0tacrvYnWroMOGhVCIjwga;25:IOyZ3zRVy3vqS8BTesRV9j2O65qAlvBNasjMs8XpWUkRl54sdBPgk2cAAAPz1PlwazvAWO2Xt1AgCjdwgnDcLVwk9rnMcx9Hge5CNtxyZnqwuzCHOAxVwQSR+me6/600q+4Mx9paduZZMJye8S+q5TO/4V71eSh1mtX2rUx5KAC+D7D6ldH8nyc3i3Q/4EKOZVg06jolOphHPNT9IoYzVeEk8tqbHQQCqs4xWThLw/r/wN7KRdQ8xXr7SMc5pb+IAwhtfa7lpvlPN+ilbxVZ1TAOu0J2HBQQFoC35qnVTCFpYwqP5tyjZdXxEf4095lTkyfE9gh5Or+hcBvz26Q/e8xJzpvw16tZlqyyXuTFDL8=;31:AC5gxqoDZ175azg+kFgOkrnEVXz1A6iQP09xYrrXFYJvu7f3hNhzZBW70WBuu+ontpD9wAsAbeKPdxPXS0XWX6nM7KdI6OqbG1Rq/eQguhAPCO3GoBCgb14NZc/yAX6CgAgQwSIUNBHpI17F8FEFzQALjlmwUa1207kynbpYSKyQ2o3fg58u0B4uOWJ3Nkb4y5TKOY2Rc9ciQfg+q/xSC34qBzJXw/hynxIa8MTiH7I= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;20:YAYVv9fs0wWWMwjJBnfoCcsyXsJH6LuseYLfslt9T9g3puFMKWDuoBnuSwDuc7ZEkl4W736bJ+rYAyNlO5w+olM77fQUAHvSPcbAsxjr/USxh+UFf3QiQBdhvWZOtClEjAxHMnTt2KdvtneFdDv5rvgxGDnOaIWAEcktbIIRUcf3kXSd/k06Uq8Dqm0fo46I2/EycwXCBKO0QuV5lm1GMyDbtep595BCbwGiR/EKU5ILR3mcFy8fIa8kekRbZZ4tDu2JZmsbx3CRmueKtUXpyinMZBcfcPlDehJULlIOLDlbneqWnCBDYLd+qOVok+kTVyVlVcSLs4PDzAREHeTC74xOiWbEF4S4ASC5ajSGgqspbqm0VFQoG3JY3e19wBSPR5+7M+evJe0jEjVxitma4EAbyWiR5ok4ko84aa6ESJzm41eAqb2bk/KfHatvmsSAMcbSQH8X0mEzroHlADCQKegcdba9rZSMCGEuF79AkSylJuLTwAVMSUu7zQDmVS5M;4:0N6vLhuhsN5mfViBPFcUVcjVjo+4IRdT5FfCLTaEeo5f94uVTfmYFXEyXQUMqXqZP5pt92Zt9I11ZifTVBj4lP1e+Rus1rLF5moQLNXrXScPsgrX5nZZjvuCU2DUK+3LYGLlG5/KXoEq3bgtB9hqEuiG5nZQkI18QOaigG/qqbCMR3gY+VAWdFJoNljaw5ku7bOuxD4aR7IRcu1fbwtPN7MAGqxNh2ByDLlo6/ZddwToBI+h/hkm7lMKUUTFeBFYNlO10wZjxAzyY3VQ9qW70A== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(10201501046)(3002001)(6041248)(20161123558100)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB318;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB318; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(376002)(346002)(24454002)(199003)(377424004)(189002)(5660300001)(36756003)(64126003)(53546010)(105586002)(230700001)(31686004)(31696002)(86362001)(33646002)(106356001)(50466002)(25786009)(58126008)(83506002)(110136005)(8676002)(2906002)(49976008)(97736004)(68736007)(93886005)(16576012)(478600001)(305945005)(4001150100001)(7736002)(8936002)(81156014)(189998001)(81166006)(4326008)(229853002)(6666003)(65826007)(3846002)(6486002)(2950100002)(53936002)(16526018)(65956001)(23676002)(66066001)(65806001)(6246003)(50986999)(101416001)(47776003)(316002)(54356999)(76176999)(6116002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB318;H:[142.133.61.28];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTg7MjM6Wk43OFdpZ3RSWnVnc2RPTXppUjFqZHF6U202?= =?utf-8?B?MDI3MUU3U3QyQTNNWkdlZ2h0ZkMyRWhYZy90SXM4WFI1SkVsclJEMWp2V0Z5?= =?utf-8?B?ckJXcVQ1UG5yd3U3L3hWeDhXdnZVRjZ5SSthWDBMSWI2UW5WQ093ZHZDd2RN?= =?utf-8?B?Tmg3TkhIWEJyQXkwMU44QnlVUmhQZWc5RUJBNGNmcm9JWFMweGhaaFRiZUhh?= =?utf-8?B?NkRZTnZHMG4zdnhHODEzWEtTMnBiQ0dLZVhhcXFlQUw2SGc4NDhXL3RPN0xh?= =?utf-8?B?K20zV0twZkRYcm1RZ3pnMFE0WXZoL3hNLzk1d0tKOTdWS3NZUEJUcWU5OGx6?= =?utf-8?B?S3QwRkhKRitCWEt1enBIWEF3VndEYklaQkxoeXNMMmgxV1lCa1k0bGd5WlEv?= =?utf-8?B?TjU2dnY4UUpsM2t2RnNtckNoTWwyc0lqMkhCcDBraFl3dGVVWXZIaXhmR2FB?= =?utf-8?B?WGVXdXVIbUxIYlJUTXZCUGJhWktRL0x2bmpwQ1BFZkZpUjNqTDVCVERIMWgy?= =?utf-8?B?dTNUMlB6Z01lL3FtMjM5TXp0NnpRek5IRmxBbEhMeXYzVEt6aUtVTDZLaTY0?= =?utf-8?B?bzZ4RFUzY2ZVSS83SGh1YmRNUnJWaitUdWt0a3lndXUwdWh2MnFRTzUyUnJh?= =?utf-8?B?MlBTQllSMzVBeFZrWjUzM3hreTh3NDlsRFRGOWVhVTFxSzZtdGtqMHdZL0Vr?= =?utf-8?B?L3dKSDRacTJYV3U1Rzk2TVRyM1RYcURMTW5HSUJpUlFYbG9HMnpnUkRUS1ps?= =?utf-8?B?RWZlQXZZamNFYzJIRElYbXArMFJJNFE4MUtGWm1jeElWbFJLUFFHN3VUeUIw?= =?utf-8?B?QlNzOUJQVWVZbXVGOWRTdklmMGdGMlZENkt3Q0hKV2xIYzQ0SFI0eTVQbGR2?= =?utf-8?B?L3lVK0pyRUJPeGxKYm8yQThzZEJqbktPcW11OG5yTzk5TVRQUC9DTE1OcjNR?= =?utf-8?B?R3Y0cFZZUkdzcDFueDB5WThyVmNHK2ZWdEdGd01vQTB0U3ZybTBZT05jcW14?= =?utf-8?B?WXI5UE1ub3UvUHBoWWVPWlA3S1hxT3pnb2toRjUwMDRhRnRIK21iTFY3R1Fr?= =?utf-8?B?d0RWdEMwM2xPcXgwU0pOU3gyWVlBU28yS3plQU5TNStVeXBhTkpPMTFjb1d6?= =?utf-8?B?N2diWXh6Q2tQR2JQdjRUS0R0TWlxNnp6ZUJqTEIyWEFGbDU1SGdOVmcvNk94?= =?utf-8?B?aHUxaWdvOUZOTXBKSXVZVzV5czQxVUZrK0gvZlRBSy9SNklac3Q0VkY4WjJz?= =?utf-8?B?VWZXK25YVHljUnRNTnR1VVZkZVQxdVdKYjNVUHBZa3l6Nk1EeFFhMkt0eitB?= =?utf-8?B?dWc3YjQwdXY1SkJkK1I5S2RZSktjN2x6c1hsamJNNUtQTTUwVjAxbVlJdUg2?= =?utf-8?B?MWJxQitJeVlOY1VXSFZuQ09ES0ErVWVmdXdOZ2tlaXYyd0pDNWtNSmh1M3Yw?= =?utf-8?B?aU9IR2Z2OUQ3U3prS3cyTmRFMGE5MlZYdnd2YkMwY1BZSmdneHJXbzdnSFpN?= =?utf-8?B?eHYyOTQzaHBpTmMwV25GT3BST2g3ZWhtakhyVUF1bEVGcHdGRkNmTkdGWFRs?= =?utf-8?B?MDE0dmdZUkxhSEJ1NjVKRVBWNWNzckcveVc1ZzdKTWRtWXFYdlNQVVpleEJv?= =?utf-8?B?R2JJaHRaTnFxQXNaeURKaUNjdEZjY1V1VDcwY1FZY0lDSHYwUDFFd0FqZlNR?= =?utf-8?B?WHZ1MTZKNTd6VmZZdEpUdlhYVVdVTzBIbmN3WWE1UkNBUEdqTGdlRXA0Rk5p?= =?utf-8?B?dVoxdS9VMU5FWkc3dWdwQmgybnZsaVo0MEJienB6OWZrSmlwL293TCs1R2M1?= =?utf-8?B?VGdqcXhxL3h1Y2o4THo4d25peFBNbmRoWWNOc2F3Nm5XY0pGZ3JlRmpXRWc4?= =?utf-8?B?UWNrMkhrZy9IVW8xMEtPQ0duQWl5K2pCRGVvTjN4RmdaUFZFVmVQNTJmU2xs?= =?utf-8?Q?MuaUkoA6lS1NXh3l2mfHLiCN5DK1A=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;6:0oJ8aqejQao/e2p9OL8MtWImfcW7PnULSdyvFvCQe0C1rbIkpbA0phtyVeHohPMQTwRFEayAPmBeKf6YEMIO2De4EGGc8Rifeeg/BeAlT/WUOjpiH/r/b6Fa5OIyzrOFStWW+mtiozZ4sg7jmov08wBjCPx2/K9ftJsmImcMV+kKenQm7NgB3qmxVX/U8UfcwH/5lktLYxUlDzHS4kS+po9Xfke5IfHHZYeml+U2nRXWV1f4M7sLdYmrkBnrV9zLMPNvAh2BBubGl43EIWiGzQhUtqP3XQI2p1c3K+rFAuNKThhz8E8oul5SY5DXctnubJPgsI3dkV9cciIBLLDsPRDbqtaLkOb6KvKaim+1Tts=;5:istbvI9LeYoSDDBz8vxbROBEJl+QTyPGq5NwCZkrSJLzglD2TlWWjKltvbV+yWzyT4Acak0k8r/5X5sFXvfabXopTNhwCh5N6fkyj1ThOoW3Dy+9XoiEAl58XdL1l/gx+0VcmlVYENygSQPPvxXVNVPOEkWRcuFwbYDYFwF3dEQ=;24:MAIs942acr8YV3taRqrK8pKcN2OSmUWKV0OEnCmf12NHQQpsZQUu4ToOyRPvZVgi38I4AZoXcx7VKITyPOp3q7/7fMvejYnHk1GyrjU6Us8=;7:DzQqEF3O3Hpcm6C2UVvMCUW38TxG6rMLSYRiz8v2vWu2vqRm2C+HCbHDq+sX5lAyO+IKTa2aDO5Pb2WmlZpGNSAzSAjEYgc43t5s6wUrPC21LLBM8kQTtwNWLfLmdUbtpmjJDk5+XYVYkwFVjXkx0JDNcud0Y/BiZusxHS9ZkWLPve4xdd78Ah3vg6ALo/pScVWJgSXF22VRAZBv5adWjJnTpIYzkJcYFv5nC5r9fxrfYTHhPWrQ6rP/hpR1GGOj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 21:10:59.0995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 984d6a78-b18f-412e-46c0-08d51d7f3944 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00855.txt.bz2 On 2017-10-23 07:19 PM, Mike Gulick wrote: > Here is a new version of the patch. It changes the following from the original > patch: > > 1) It adds a testsuite which locks down: > a) The stack frame is printed when the breakpoint is hit > b) 'next' runs without causing a segv > 2) No longer set descriptor->size in gdb_bfd_map_section when an error is hit. > It doesn't look like this is needed as gdb_bfd_map_section is the only place > that consumes that descriptor->size field. > 3) Update the description in gdb_bfd.h to indicate that if there is an error > mapping the section, a warning is generated, *SIZE is set to 0, and NULL is > returned. > > I considered catching the error in the caller of gdb_bfd_map_section, which is > dwarf2_read_section in dwarf2read.c. It didn't seem to make any more sense to > catch the error here than it would directly in gdb_bfd_map_section. If > anything, it would make more sense to catch the error in the caller of > dwarf2_read_section, which in this case is dwarf2_get_section_info. However > there are many callers of dwarf2_read_section. It doesn't make sense to force > all of them to add a TRY/CATCH around calling dwarf2_read_section. > > Please let me know thoughts/feedback. > > Also see the note in the test case about not being able to make 'shlib=...' > work when compiling a shared library that links against another shared > library. The workaround I used is kind of ugly. Hi Mike, I started looking at your patch and thought I would take a look at this problem. The problem seems to be that gdb_compile_shlib builds the shared library in two steps: .c -> .o -> .so because it's not possible to do it in one pass. As of today, if you pass an shlib= option to gdb_compile_shlib, it will be passed to both compilation steps, which means Dejagnu will pass the path to lib1.so while compiling the .c to a .o, which makes gcc complain like this: warning: .../solib-vanish-lib2.so: linker input file unused because linking not done I think the solution would be not to pass shlib= for this step, only for the final linking. I'll try to write a patch about this. Simon