From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH] gdb: more filename styling
Date: Wed, 8 May 2024 16:00:49 +0100 [thread overview]
Message-ID: <fdb42c0cff8ca263db4ba65d0f09832ff29e9532.1715180432.git.aburgess@redhat.com> (raw)
I spotted a few places in solib.c and build-id.c where we could apply
file name styling.
Other than the extra styling, there should be no user visible changes
after this commit.
---
gdb/build-id.c | 10 ++++++----
gdb/solib.c | 16 ++++++++++------
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/gdb/build-id.c b/gdb/build-id.c
index d1ebd8d37d7..659801b0865 100644
--- a/gdb/build-id.c
+++ b/gdb/build-id.c
@@ -60,12 +60,14 @@ build_id_verify (bfd *abfd, size_t check_len, const bfd_byte *check)
found = build_id_bfd_get (abfd);
if (found == NULL)
- warning (_("File \"%s\" has no build-id, file skipped"),
- bfd_get_filename (abfd));
+ warning (_("File \"%ps\" has no build-id, file skipped"),
+ styled_string (file_name_style.style (),
+ bfd_get_filename (abfd)));
else if (found->size != check_len
|| memcmp (found->data, check, found->size) != 0)
- warning (_("File \"%s\" has a different build-id, file skipped"),
- bfd_get_filename (abfd));
+ warning (_("File \"%ps\" has a different build-id, file skipped"),
+ styled_string (file_name_style.style (),
+ bfd_get_filename (abfd)));
else
retval = 1;
diff --git a/gdb/solib.c b/gdb/solib.c
index a656b623458..db2ff5ce9a3 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -903,16 +903,19 @@ update_solib_list (int from_tty)
stand out well. */
if (not_found == 1)
- warning (_ ("Could not load shared library symbols for %s.\n"
+ warning (_ ("Could not load shared library symbols for %ps.\n"
"Do you need \"set solib-search-path\" "
"or \"set sysroot\"?"),
- not_found_filename);
+ styled_string (file_name_style.style (),
+ not_found_filename));
else if (not_found > 1)
warning (_ ("\
-Could not load shared library symbols for %d libraries, e.g. %s.\n\
+Could not load shared library symbols for %d libraries, e.g. %ps.\n\
Use the \"info sharedlibrary\" command to see the complete listing.\n\
Do you need \"set solib-search-path\" or \"set sysroot\"?"),
- not_found, not_found_filename);
+ not_found,
+ styled_string (file_name_style.style (),
+ not_found_filename));
}
}
@@ -1005,8 +1008,9 @@ solib_add (const char *pattern, int from_tty, int readsyms)
/* If no pattern was given, be quiet for shared
libraries we have already loaded. */
if (pattern && (from_tty || info_verbose))
- gdb_printf (_ ("Symbols already loaded for %s\n"),
- gdb.so_name.c_str ());
+ gdb_printf (_ ("Symbols already loaded for %ps\n"),
+ styled_string (file_name_style.style (),
+ gdb.so_name.c_str ()));
}
else if (solib_read_symbols (gdb, add_flags))
loaded_any_symbols = true;
base-commit: 868883583e7520ff1bd99fcb224d2b33a990edff
--
2.25.4
next reply other threads:[~2024-05-08 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:00 Andrew Burgess [this message]
2024-05-08 16:19 ` Tom Tromey
2024-05-08 16:50 ` Andrew Burgess
2024-05-08 17:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb42c0cff8ca263db4ba65d0f09832ff29e9532.1715180432.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).