From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id B6FAD385840F for ; Mon, 22 Apr 2024 17:22:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6FAD385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6FAD385840F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713806566; cv=pass; b=jYZhzYwAnD3nQ/gaMapfmDH5AU35ubVF/cSNlzDpWJn9/iutr1BO1pwkdG3E6k95i3V6Fp1NegVk0WeUthR8FILu+0Vt7hPHSApJ7O1O9glP9TUtMlorRwiAvh3vCRlZzGZqxTMBZcP63/Ot3cJCTlyHokOG5wvDukA2Oxh9gng= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713806566; c=relaxed/simple; bh=QJXvEowHzJS75aDO+zqSqbUlbdL4DE3Umv95isgheeA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BHgyFFfaWdSrAHqVRw4H5VR0jNjOsQ6bXOe/fDxZ30vftnENoC89bkzZlsOAaPVKeT+Udf/L+9BnLHklKNHqc7vRlIDEyFpzaunYEugyeh5iIBXNncGiyr0knNPABq+jDdd45Lng4Yf1Zpbh0YhaVw5RXY93JnQwSWnctNaTDh4= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VNXBX3kGyz3tPn; Mon, 22 Apr 2024 17:22:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VNXBX2Yzmz4RCw; Mon, 22 Apr 2024 17:22:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713806564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/DHywg/vss2NYn9I5snqRG8c/tlcx+GWFBmQ7B8LuA=; b=X3K0ZePC+L7KTqhPI6489yYZfeDCSGsaqg7FVnB+OgEO4nH+HYe4dc4O4gFiZqrFEQpOfy JPy+LZJWiVgQ0eC/9i82nj0jP80tHuTUwzVLvbZK+hq/HHsJZ3GEXZZZh82lIxC19QDFn9 hwXXSHIU5USYMSqTfZ11PuqdQqtWsKeQe+eglFYgErl6/E9fe9bTG6NAwIDT8p0cbm9mMJ PrvPkQwO4owYcWOPCetyLcaxd0GdwqLAbRid+17yfeuhc7TngMP3+0i08itjtIsDGlPAww UCvWWxNICIQdBhk9rlETdak6VJqn6uyRggNDlH5jeTLF/9OUTiT9LtWxmaiG6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713806564; a=rsa-sha256; cv=none; b=YYYehYH5NfctfHL0dISxv6b0CxvpjH7KUOH4vlhzNF4f6Ui70OJxLQOQ16XLeAX3VM41yx QUOYoYnbdvbwHM47UBo/HAzmsLqnCES567m9fJIUmOE2IDDtDJx/yvzKnRo4XgCSdshN1O 3BDtXvMJP4/UuhvQqqjZD8RZQ5edYQ2gxpQr1OMqlLTEFrtyNYBJbH7OATh7Ls3oyajU6n m/Pg0gaL4cp5KDdD4Uhm+7DH0KYHfae5uayrVwS4qqU4Wgc+hbUg2hrz8QIScL0hszPSbO TKn6qlS1dopTH57vujiSck9mIOM19RRklWeNyaKWKAVhhtM5hL57lwwYBVSh9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713806564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/DHywg/vss2NYn9I5snqRG8c/tlcx+GWFBmQ7B8LuA=; b=XwQPYCcQYu9WkvTvCDp6njF+QGsIhYfKRQpRHXadRKUUKAeJ0wIgJq3cZbIW+P24ACmRZx o7P9acQEOsxdGEHOo5j2dgWXadlF0Vm7vgwSxJwiQyZTOr+ht1gxkenXgR+oMLsf8iv7ES At7lV0nfxx2J11cApId3z3odUlzTp0F2DuWSLtyw+kKAAB0INO9QBoWYX9LrfVoP66YWW5 I0QUnBBLLGOIVolv9JGjRddYef+gg+jXrUnsp8dYGYJgUE7p/4SE2GyW9nEzKktpnxIyME H5B3xS43ge/KHosLuAmK/cIlSa4YzzYymNAOdMOWqJ7y3wagdYhbmXZXKIj7Bw== Received: from [IPV6:2601:644:937f:4c50:48e:b274:3ff6:85b] (unknown [IPv6:2601:644:937f:4c50:48e:b274:3ff6:85b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VNXBX0Ls2z1QMR; Mon, 22 Apr 2024 17:22:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 22 Apr 2024 10:22:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] Fix C++ canonicalization of hex literals Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240421-canon-fixes-v1-0-4dc4791d270d@tromey.com> <20240421-canon-fixes-v1-7-4dc4791d270d@tromey.com> From: John Baldwin In-Reply-To: <20240421-canon-fixes-v1-7-4dc4791d270d@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/21/24 10:00 AM, Tom Tromey wrote: > Currently names like "x::y::z<1>" and "x::y::z<0x01>" canonicalize to > different things. I think it's nicer for them to be the same. > Differences between types can be done using suffixes like "ll" and "u" > -- it's not really possible to implement C++ rules in the > canoncalizer, because no gdbarch is available. Possibly gdb should > even drop the type here and just represent all integers the same way > in names. Approved-By: John Baldwin -- John Baldwin