From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 14830384F497 for ; Mon, 21 Nov 2022 20:24:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14830384F497 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ALKOb50002174 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Nov 2022 15:24:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ALKOb50002174 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1669062282; bh=DCnlOcCOspBqr66/grWYjYdRzWXE6DMAk2kHQAaQ6vI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=bEXQyWDjbpv8dV41TGwfS9Vgq6yquLxAz72mIj63nB3OeP7sl2QN50FoYhYgN7r8Z GXHVCnEum/wsWE5Oi4qqwPa4lsWLf6PItJsDpF1lwyE9rw2HVTUcEd4oFfdQ82Tik4 xXot1+YoHvJArWkeHre9pgNaBD0axsU1ChKGgY9s= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1CE431E0D3; Mon, 21 Nov 2022 15:24:37 -0500 (EST) Message-ID: Date: Mon, 21 Nov 2022 15:24:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] gdb: add "set debug solib" and use it Content-Language: en-US From: Simon Marchi To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20221121193636.1479004-1-simon.marchi@polymtl.ca> <83zgck13q4.fsf@gnu.org> <7dc71740-a5ca-0c47-134f-a02d58026ce4@polymtl.ca> <83y1s412n5.fsf@gnu.org> <65327b23-1e3c-b9c9-6e42-f8c039905bdf@polymtl.ca> In-Reply-To: <65327b23-1e3c-b9c9-6e42-f8c039905bdf@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 Nov 2022 20:24:37 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/22 15:24, Simon Marchi wrote: > > > On 11/21/22 15:19, Eli Zaretskii wrote: >>> Date: Mon, 21 Nov 2022 15:02:08 -0500 >>> Cc: gdb-patches@sourceware.org >>> From: Simon Marchi >>> >>>> Not sure I understand: we already have "set debug aix-solib" and "set debug >>>> solib-frv". So this is going to be "set debug svr4-solib"? Or do you mean >>>> to make a single "set debug solib" command for all platforms? >>> >>> The new command was intended to be used by all solib implementations, >>> but I missed the existing commands you pointed out. I think it would be >>> fine to have a single knob for all solib implementations. In general, >>> only one solib implementation will be used at any given time. >>> >>> If you agree, I would remove the two existing commands in favor of the >>> new "set debug solib", and then add my solib-svr4 changes. >> >> I have no use for those two commands, but I guess users of AIX and FRV do? >> Can we just delete the commands from under their feet? > > I tend to view "set debug" commands, as internal commands (maybe they > should be maintenance commands, really), I wouldn't feel bad to just > remove them. Or we could keep them as deprecated aliases of the new > command. Or, I could just add "set debug solib-svr", if that makes solib-svr4, sorry. Simon