From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D93AD3858D1E for ; Fri, 12 Jan 2024 14:56:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D93AD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D93AD3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705071397; cv=none; b=t8zJpBmhzGvsv/WWzQNx5UbdOjLakBmjDAHz57W3U0WeOB/Tct+IkJyUWRgwhm+JHklhK9bzNGbp84cJ3YdHN3uME9S8jDwwK730zt5VUYGwYq45LfcViiVbB52ZIYLSg81Ck+pgJtDU0QJYhxeL6bPj/CU7cpHPdunQ8095rEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705071397; c=relaxed/simple; bh=7BEFOkwlqZ30rfEVcs87dAF5Ez8y9+wnxQrrwQ2hVQI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=BkaP7J3m11/bQpY8AMOjZ4QB+kBhNERNqDjo4ZxaNO9hQTaleZGYYuTqx9yG4NX9zAlx73AvB/tPMbB/rHucvqVaP/TiCBcrObyv4jnFbhmR02L7mnAugMiJjPkIdt43YNtZ9LKaY51d9+nmyiAaAqAKJTCUm7wd/jKPw/H2ABI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BF0C62228A; Fri, 12 Jan 2024 14:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705071393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aqy6itfnP4ikCG8ZipqlJWW3Ys+mV7Glvgez7nEG7vE=; b=t+cVmi5OHR7qxYsi8Tjk/hMkZUATQ06VY0sS4/ZrvzY+7Xf2vCHHscGNuDhdfqkqoDqLYn h+6pBLTYzrUIX36n2LZlsir5cBfYl8er6z+sgazR+12FsfqJwoK70eQ5z67jOjlUUhhgST fBcl8QEpbqo79H+azbz1uVOSbwope68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705071393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aqy6itfnP4ikCG8ZipqlJWW3Ys+mV7Glvgez7nEG7vE=; b=D165BcTgsyCUhpvKDkVUGSmIKB4Qol/nyO9I12jh3T0dTbauKS3Cgt0btxa5iTrPchi9C5 E8+YMkWmT6etmJDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705071393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aqy6itfnP4ikCG8ZipqlJWW3Ys+mV7Glvgez7nEG7vE=; b=t+cVmi5OHR7qxYsi8Tjk/hMkZUATQ06VY0sS4/ZrvzY+7Xf2vCHHscGNuDhdfqkqoDqLYn h+6pBLTYzrUIX36n2LZlsir5cBfYl8er6z+sgazR+12FsfqJwoK70eQ5z67jOjlUUhhgST fBcl8QEpbqo79H+azbz1uVOSbwope68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705071393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aqy6itfnP4ikCG8ZipqlJWW3Ys+mV7Glvgez7nEG7vE=; b=D165BcTgsyCUhpvKDkVUGSmIKB4Qol/nyO9I12jh3T0dTbauKS3Cgt0btxa5iTrPchi9C5 E8+YMkWmT6etmJDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9C10213782; Fri, 12 Jan 2024 14:56:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mNYgJCFToWUZDwAAD6G6ig (envelope-from ); Fri, 12 Jan 2024 14:56:33 +0000 Message-ID: Date: Fri, 12 Jan 2024 15:57:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 0/8] Python __repr__() methods and new __dict__ attributes Content-Language: en-US To: Andrew Burgess , Tom Tromey Cc: gdb-patches@sourceware.org References: <87mstdrrgw.fsf@tromey.com> <87msta7jk7.fsf@redhat.com> From: Tom de Vries In-Reply-To: <87msta7jk7.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.84 X-Spamd-Result: default: False [-1.84 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.55)[80.87%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/12/24 14:44, Andrew Burgess wrote: > Tom Tromey writes: > >>>>>>> "Andrew" == Andrew Burgess writes: >> >> Andrew> In V2: >> Andrew> - Fixed problems in thpy_dealloc that Tom pointed out, >> >> Andrew> - Used @group...@end group in the docs as suggested by Eli, >> >> Andrew> - Added patches #7 and #8, which are both docs only patches. The >> Andrew> first adds advice for naming attributes as Tom suggested, the >> Andrew> second is just some doc updates that I noticed in passing. >> >> Thanks, this looks good & addresses my comments. >> Approved-By: Tom Tromey > > Pushed. > Hi Andrew, I'm seeing this new FAIL: ... FAIL: gdb.python/py-inferior.exp: test repr of an invalid thread ... Filed as https://sourceware.org/bugzilla/show_bug.cgi?id=31238 . Thanks, - Tom