From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C92D43858D1E for ; Tue, 3 Jan 2023 09:00:08 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672736408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XRbUApYuPxY9e4esq4wJsLM3ysiMSrEs/q03flmy8WM=; b=M3Ce+teY/dyUm2jGj73OsuKL40BDqGKiMkwa/ttQiGXYzcVhs8KZkjla2xGJnsqbMBr6yG pNXbc/UHF26aQGnjZQzxX/pVUUPiV/+BNLK1OQ+aIje9GWl9U48KfOFi1rL7+44sUva6JS MiVe6rQRvvsob8FEuo9z4yHNBcaUPyQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-578-dneSkG-rMJ27sSa6zZxwjg-1; Tue, 03 Jan 2023 04:00:07 -0500 X-MC-Unique: dneSkG-rMJ27sSa6zZxwjg-1 Received: by mail-wm1-f69.google.com with SMTP id j1-20020a05600c1c0100b003d99070f529so10484458wms.9 for ; Tue, 03 Jan 2023 01:00:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XRbUApYuPxY9e4esq4wJsLM3ysiMSrEs/q03flmy8WM=; b=OC6r1MH8xMT/pKqReOo5UJ+7s6I23yW8hjpJrSop0aGe2qYfpeTGNVNEHMnIlgjHPX H6x0S+hOf2V/raYlRlgYjceRwkONtp8NirhZvLjrAO3VJesXfRcSQWItkKQIKlFFxqby az1/tc8ELI7mIrocJr4eQWFDbXHZCyYWTn7DLPMDj70YLM6YqIjyHWRDnHaRPEnDebEj CAok2A3EJ6LNfpVXAry7nkm19sWQZ8szK8Rxhk54Ij7ZqJvQzTk6MYbP2UeWBo065Bis CyIYHXdpYR/HwcY0wQbA+lA2ynYDuY+dPA0cDDpo0D35UcypIFeL2A5SO0DzFg0AZlRC W+Fw== X-Gm-Message-State: AFqh2kq0ppa88A/BX7zfK/eREMR/O3rkxeQ79w62SZaEHaKs1JRgYSpR SRyLjoNO8as1bR2aXeIm6PV5x3bYbc3sm7jVxCD9+9OsLasKmmLLSHSZCz7MyWv9Ls1d1JKOOS6 km1ffou34TLnBEq3OqWVOgg== X-Received: by 2002:a5d:4b41:0:b0:283:7ce6:dd57 with SMTP id w1-20020a5d4b41000000b002837ce6dd57mr18129295wrs.35.1672736406317; Tue, 03 Jan 2023 01:00:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXsdqwQXjo0cEnpnEhLa85mR574xGKITRkLhgQpbhsjIQWhdQg5DJrxvBGlHgL/nEvpIBJLLvA== X-Received: by 2002:a5d:4b41:0:b0:283:7ce6:dd57 with SMTP id w1-20020a5d4b41000000b002837ce6dd57mr18129267wrs.35.1672736405974; Tue, 03 Jan 2023 01:00:05 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b00281eab50380sm23898889wrw.117.2023.01.03.01.00.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 01:00:05 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 10:00:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command To: Alexandra Petlanova Hajkova Cc: gdb-patches@sourceware.org, Eli Zaretskii References: <20221222154338.2223678-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/01/2023 16:37, Alexandra Petlanova Hajkova wrote: > > +# This file is part of the GDB testsuite.  it tests the > functionality of > +# the maintenance print record-instruction command, but does not > check the > +# syntax, only if the command finds or fails to find recorded > history. > + > +if ![supports_reverse] { > +    return > +} > + > > > I think this patch is good to go in general. >  But it might be nice to add a small summary about how the test works > as a comment at the beginning of the test? > I see. I've expanded that starting comment to the following: # This file is part of the GDB testsuite.  It tests the functionality of # the maintenance print record-instruction command, but does not check the # syntax, only if the command finds or fails to find recorded history. # This is done by putting the inferior in mulpitle states with and without # history to be printed, then checking if GDB is able to print an # instruction or not. # To identify if GDB has printed an instruction, we can see if some # change is printed, since any instruction must have at least a change # to the PC. What do you think? -- Cheers, Bruno > Regards, > Alexandra