From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>,
Thiago Jung Bauermann via Gdb-patches
<gdb-patches@sourceware.org>
Cc: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply
Date: Wed, 1 Feb 2023 12:37:31 -0500 [thread overview]
Message-ID: <fea2ac3d-495b-55f2-9738-e08190c946b4@simark.ca> (raw)
In-Reply-To: <87lelhtwqv.fsf@redhat.com>
On 2/1/23 07:07, Andrew Burgess via Gdb-patches wrote:
> Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org>
> writes:
>
>> Now that an inferior thread can have a different target description than
>> its process, there needs to be a way to communicate this target
>> description to GDB. So add the concept of a target description ID to the
>> remote protocol, which is used to reference them and allows them to be
>> transferred only once over the wire.
>>
>> The ID is an unsigned integer, and is sent in the 'T AA n1:r1;n2:r2;...'
>> stop reply packet as a new 'n:r' pair, where n is "tdesc" and "r" is an
>> unsigned integer containing the ID.
>>
>> It is also sent in the threads list XML in the response of a
>> qXfer:threads:read request. The ID is sent as a new "tdesc" attribute of
>> the <thread> node.
>>
>> To request the target description XML of a given ID, GDB sends the
>> qXfer:features:read request with "target-id-%u.xml" as the annex, where %u
>> is the target description ID.
>
> Luis already commented that in some locations the ID is hex, while in
> others it is not explicitly stated if the value is hex or decimal. I'd
> like to second that feedback, and suggest that we pick one, and use that
> consistently throughout.
>
> My thinking is that it will be easier to understand remote packet traces
> if target descriptions are requested using an ID in the safe format as
> was sent to GDB, and if IDs in different packets match up.
>
> Thus, I would suggest we switch to using 'target-id-%x.xml' here, and
> send the ID as hex in the threads reply packet.
Not that I disagree with you, but I just wanted to note that this
decimal / hexadecimal mismatch already exists for the core field. It's
hex in stop replies, decimal in XML. The thread id, however, is always
hex (the special thread-id syntax).
Regardless how this new field is formatted, it would be nice to be
explicit about the core field too.
Simon
next prev parent reply other threads:[~2023-02-01 17:37 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 4:45 [PATCH v3 0/8] gdbserver improvements for AArch64 SVE support Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 1/8] gdbserver: Add assert in find_register_by_number Thiago Jung Bauermann
2023-01-31 17:05 ` Simon Marchi
2023-01-31 19:49 ` Thiago Jung Bauermann
2023-02-01 15:43 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 2/8] gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap Thiago Jung Bauermann
2023-02-01 9:07 ` Luis Machado
2023-02-01 10:54 ` Andrew Burgess
2023-02-01 16:01 ` Simon Marchi
2023-02-01 19:33 ` Thiago Jung Bauermann
2023-02-01 19:53 ` Simon Marchi
2023-02-01 21:55 ` Thiago Jung Bauermann
2023-02-06 19:54 ` Pedro Alves
2023-02-06 20:16 ` Simon Marchi
2023-02-07 15:19 ` Pedro Alves
2023-02-07 21:47 ` Thiago Jung Bauermann
2023-02-09 1:31 ` Simon Marchi
2023-02-10 3:54 ` Thiago Jung Bauermann
2023-02-07 22:28 ` Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 3/8] gdbserver/linux-aarch64: Factor out function to get aarch64_features Thiago Jung Bauermann
2023-02-01 8:59 ` Luis Machado
2023-02-01 16:04 ` Simon Marchi
2023-02-01 22:13 ` Thiago Jung Bauermann
2023-01-30 4:45 ` [PATCH v3 4/8] gdbserver/linux-aarch64: When thread stops, update its target description Thiago Jung Bauermann
2023-02-01 9:05 ` Luis Machado
2023-02-01 11:06 ` Andrew Burgess
2023-02-01 16:21 ` Simon Marchi
2023-02-01 16:32 ` Luis Machado
2023-02-02 2:54 ` Thiago Jung Bauermann
2023-02-02 3:47 ` Simon Marchi
2023-02-03 3:47 ` Thiago Jung Bauermann
2023-02-03 11:13 ` Luis Machado
2023-02-04 15:26 ` Thiago Jung Bauermann
2023-02-03 11:11 ` Luis Machado
2023-02-04 15:21 ` Thiago Jung Bauermann
2023-02-06 9:07 ` Luis Machado
2023-02-06 12:15 ` Thiago Jung Bauermann
2023-02-06 20:29 ` Pedro Alves
2023-02-07 8:11 ` Luis Machado
2023-02-07 14:39 ` Thiago Jung Bauermann
2023-02-03 10:57 ` Luis Machado
2023-02-04 6:18 ` Thiago Jung Bauermann
2023-02-06 20:26 ` Pedro Alves
2023-02-07 21:06 ` Thiago Jung Bauermann
2023-02-09 2:46 ` Simon Marchi
2023-02-10 3:29 ` Thiago Jung Bauermann
2023-02-10 14:56 ` Luis Machado
2023-02-10 15:04 ` Tom Tromey
2023-02-10 15:28 ` Luis Machado
2023-02-10 17:26 ` Thiago Jung Bauermann
2023-02-10 21:01 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply Thiago Jung Bauermann
2023-01-30 12:52 ` Eli Zaretskii
2023-01-30 14:05 ` Thiago Jung Bauermann
2023-02-01 9:39 ` Luis Machado
2023-02-01 12:07 ` Andrew Burgess
2023-02-01 13:03 ` Eli Zaretskii
2023-02-01 17:37 ` Simon Marchi [this message]
2023-02-02 20:36 ` Thiago Jung Bauermann
2023-02-02 20:56 ` Simon Marchi
2023-02-01 20:46 ` Simon Marchi
2023-02-02 21:43 ` Thiago Jung Bauermann
2023-02-01 14:51 ` Andrew Burgess
2023-02-01 17:03 ` Simon Marchi
2023-02-02 19:52 ` Thiago Jung Bauermann
2023-02-02 20:51 ` Simon Marchi
2023-02-03 2:44 ` Thiago Jung Bauermann
2023-02-03 16:29 ` Andrew Burgess
2023-02-04 6:08 ` Thiago Jung Bauermann
2023-02-03 11:22 ` Luis Machado
2023-02-03 12:50 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 6/8] gdb/remote: Parse tdesc field in stop reply and threads list XML Thiago Jung Bauermann
2023-02-01 9:52 ` Luis Machado
2023-02-05 0:06 ` Thiago Jung Bauermann
2023-02-06 9:10 ` Luis Machado
2023-02-01 14:32 ` Andrew Burgess
2023-02-01 19:50 ` Simon Marchi
2023-02-01 20:16 ` Simon Marchi
2023-02-03 11:27 ` Luis Machado
2023-02-03 13:19 ` Simon Marchi
2023-02-03 16:33 ` Andrew Burgess
2023-01-30 4:45 ` [PATCH v3 7/8] gdb/aarch64: Detect vector length changes when debugging remotely Thiago Jung Bauermann
2023-02-01 9:58 ` Luis Machado
2023-02-01 15:26 ` Andrew Burgess
2023-02-01 20:20 ` Simon Marchi
2023-02-03 11:31 ` Luis Machado
2023-02-03 16:38 ` Andrew Burgess
2023-02-03 19:07 ` Simon Marchi
2023-01-30 4:45 ` [PATCH v3 8/8] gdb/testsuite: Add test to exercise multi-threaded AArch64 SVE inferiors Thiago Jung Bauermann
2023-02-01 10:10 ` Luis Machado
2023-02-06 19:11 ` [PATCH v3 0/8] gdbserver improvements for AArch64 SVE support Pedro Alves
2023-02-06 20:05 ` Simon Marchi
2023-02-06 21:06 ` Pedro Alves
2023-02-07 13:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea2ac3d-495b-55f2-9738-e08190c946b4@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).