From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Change objfile_to_objfile_object to return a new reference
Date: Sun, 16 Sep 2018 01:28:00 -0000 [thread overview]
Message-ID: <fead3c06-328b-5ba8-6e1d-000de8d60b93@simark.ca> (raw)
In-Reply-To: <20180913053007.11780-3-tom@tromey.com>
On 2018-09-13 1:30 a.m., Tom Tromey wrote:
> This changes objfile_to_objfile_object to return a new references and
> fixes up all the uses.
>
> 2018-09-12 Tom Tromey <tom@tromey.com>
>
> * python/python-internal.h (objfile_to_objfile_object): Change
> return type.
> * python/py-newobjfileevent.c (create_new_objfile_event_object):
> Update.
> * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
> Update.
> * python/python.c (gdbpy_get_current_objfile): Update.
> (gdbpy_objfiles): Update.
> * python/py-objfile.c (objfpy_get_owner, gdbpy_lookup_objfile):
> Update.
> (objfile_to_objfile_object): Return a new reference.
> * python/py-symtab.c (stpy_get_objfile): Update.
> * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
> Update.
I'm also getting some failures with this patch;
CXX python/python.o
/home/simark/src/binutils-gdb/gdb/python/python.c:1432:12: error: assigning to 'PyObject *' (aka '_object *') from incompatible type 'gdbpy_ref<>' (aka 'gdb::ref_ptr<_object, gdbpy_ref_policy<_object> >')
result = objfile_to_objfile_object (gdbpy_current_objfile);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/simark/src/binutils-gdb/gdb/python/python.c:1451:17: error: no viable conversion from 'gdbpy_ref<>' (aka 'gdb::ref_ptr<_object, gdbpy_ref_policy<_object> >') to 'PyObject *' (aka '_object *')
PyObject *item = objfile_to_objfile_object (objf);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The rest of the changes looks good to me.
Simon
next prev parent reply other threads:[~2018-09-16 1:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:30 [PATCH 0/4] Disallow the return of borrowed references Tom Tromey
2018-09-13 5:30 ` [PATCH 1/4] Change pspace_to_pspace_object to return a new reference Tom Tromey
2018-09-16 0:57 ` Simon Marchi
2018-09-16 12:59 ` Tom Tromey
2018-09-16 1:19 ` Simon Marchi
2018-09-16 1:58 ` Simon Marchi
2018-09-16 13:01 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 2/4] Change objfile_to_objfile_object " Tom Tromey
2018-09-16 1:28 ` Simon Marchi [this message]
2018-09-16 2:00 ` Simon Marchi
2018-09-13 5:30 ` [PATCH 4/4] Remove CPYCHECKER_RETURNS_BORROWED_REF Tom Tromey
2018-09-13 5:30 ` [PATCH 3/4] Change thread_to_thread_object to return a new reference Tom Tromey
2018-09-16 2:11 ` Simon Marchi
2018-09-16 13:32 ` Tom Tromey
2018-09-16 14:05 ` Tom Tromey
2018-09-16 15:35 ` Tom Tromey
2018-09-17 0:52 ` Simon Marchi
2018-09-17 5:31 ` Tom Tromey
2018-09-16 0:56 ` [PATCH 0/4] Disallow the return of borrowed references Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fead3c06-328b-5ba8-6e1d-000de8d60b93@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).