From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A962C3854165 for ; Mon, 31 Oct 2022 12:45:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A962C3854165 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667220339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40LDT7DIaACbRYkwaL9iVsD4fy1iCXyAvDP5lK7MUa0=; b=L9g+UoFlQWgp65kJ6zU4bzDVewqAj8slVeCmv7mybcy+fIxFctAd8ccw8URJ6zoLhgeHlF JUVqdFL7Qll4BQZz1J6eBReTT8tjvjAE6jRS+DrX6GV9q32H6+WxVljGz2kbW4MusIA2Ex G/6NRXBH3Kl7QitDKlilUZIElnZVt8Y= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-539-Ukr30zwdNkaRqAmtSSuDMQ-1; Mon, 31 Oct 2022 08:45:38 -0400 X-MC-Unique: Ukr30zwdNkaRqAmtSSuDMQ-1 Received: by mail-qv1-f70.google.com with SMTP id g1-20020ad45101000000b004bb5eb9913fso5715916qvp.16 for ; Mon, 31 Oct 2022 05:45:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=40LDT7DIaACbRYkwaL9iVsD4fy1iCXyAvDP5lK7MUa0=; b=X1cWyN75+TH/9wA8kq9LVTIxnypxhTcAakLW2NFnxIn/7aocv2LkscMP2lhhKrf6VG sc0imp5pk16Cm0aFX/8K+KQqN5a00ry7ENQKrXBAmYpnZ0eZ6TcS+hcDXhKvFf4t1GyY X7RJfPvCRLuotv9b9RDQMuJ6BGIIGRiL1Pm1W0cNlTU6GDF+JTjbxeRbI6LsWSns3ht+ 4uLNziwJPASDCwrncOf5QZoEZD46W6/P6gcdirVtO7CQVyXp/U3qKrpSgX1og+azeqxd fu+pgnsa1wCe2sOYX+N63YFAF57dQC7tUthxPVLhcXGJeIcR8N+/jjqUWQmEpveke4Yu QIDg== X-Gm-Message-State: ACrzQf1fsEIxfSH4c3S3uVtnUfFKShOy5BYIKS+zoiENHr/bNTl5Yqnx To/CMVUSPAIJzV8lNPpnrNZ+Zp5dkwWcPwkcxlYM9Ugdm2QSItDI5PjH5AVPnPqU+LY/UTuo0iB 10Qiid47NVm7Ed+g42NfQNQ== X-Received: by 2002:a05:6214:2303:b0:4ad:58f2:7ca4 with SMTP id gc3-20020a056214230300b004ad58f27ca4mr10404567qvb.89.1667220337495; Mon, 31 Oct 2022 05:45:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7G8u+Uy2VnIQ65WdXByGc4fUpS/S3rgK43m8Fa6VuF6E4wVl65qp8oixrJIuF/wUPlkQH0AQ== X-Received: by 2002:a05:6214:2303:b0:4ad:58f2:7ca4 with SMTP id gc3-20020a056214230300b004ad58f27ca4mr10404552qvb.89.1667220337261; Mon, 31 Oct 2022 05:45:37 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id z21-20020ac875d5000000b00398df095cf5sm3562148qtq.34.2022.10.31.05.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:45:36 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:45:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/11] gdb/testsuite: add XFAIL to gdb.cp/ptype-flags.exp when using clang To: Andrew Burgess , gdb-patches@sourceware.org References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-8-blarsen@redhat.com> <8735ba7k4b.fsf@redhat.com> <87fsf8ch5w.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <87fsf8ch5w.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/10/2022 13:38, Andrew Burgess wrote: > Bruno Larsen writes: > >> On 26/10/2022 16:08, Andrew Burgess wrote: >>> Bruno Larsen via Gdb-patches writes: >>> >>>> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >>>> failure when printing the type of a class with an internal typedef. This >>>> happens because clang doesn't add accessibility information for typedefs >>>> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >>>> for more info). To help with clang testing, an XFAIL was added to this >>>> test. >>>> --- >>>> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> index f88c83e03ce..e8d3f285803 100644 >>>> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> @@ -30,11 +30,18 @@ if ![runto_main] then { >>>> return >>>> } >>>> >>>> +if {[test_compiler_info {clang-*-*}]} { >>>> + set using_clang true >>>> +} else { >>>> + set using_clang false >>>> +} >>> Missing the language for the test_compiler_info call. Looks good with >>> that fixed. >> Great! Can I add an Approved-by tag to the patch? > Sure, with that fix made. Thanks! I pushed this patch with the change Cheers, Bruno > > Thanks, > Andrew > > >> Cheers, >> Bruno >> >>> Thanks, >>> Andrew >>> >>>> + >>>> gdb_test_no_output "set language c++" "" >>>> gdb_test_no_output "set width 0" "" >>>> >>>> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>>> {raw 0}} { >>>> + global using_clang >>>> >>>> set contents { >>>> { base "public Base" } >>>> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>>> } >>>> >>>> if {$show_typedefs} { >>>> + # Clang does not add accessibility information for typedefs: >>>> + # https://github.com/llvm/llvm-project/issues/57608 >>>> + if {$using_clang} { >>>> + setup_xfail "clang 57608" *-*-* >>>> + } >>>> lappend contents { typedef public "typedef Simple > Z;" } >>>> } >>>> >>>> -- >>>> 2.37.3