From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id ED74938582BC for ; Wed, 18 Oct 2023 07:17:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED74938582BC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED74938582BC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697613429; cv=none; b=XbysmMEHPdNRcAd6q9FEbBy9e/rBVeTXhvEZZurQi4CKYcMg8HEQDkEWDmB8AuFYH9xRgZZZnbH5JtZDYs+Mrc+z5HPslGXgNJpzNolT9XzF59Z4gl7GuSKifXl1pfmhHVQFCJDeSxAc4rNpl4sBJQFtGhhYoRvn95Y9H0dGb60= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697613429; c=relaxed/simple; bh=oG2en/x8A0U0IwIPNDHzIcQsZmMXO6cxg7o1FfSE57A=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=dya9nEMpgJfPW9a8wOa1ZT+bx5C1JD3/IE8/uCj68q29Lid09Kjs5c3lZWfnNTpRhyFTkAqY8Oi4y+gW8xtP/tLpewLiccg0i+bRUPoWkggBCaqY+lVdm/ZcrxBt2yrlqvphqaPooETseK7OWCHbCKZAYcintzZUDeIimPTS1iE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B80AB1FD76; Wed, 18 Oct 2023 07:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697613425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sx+OF55aLjdy7xI7hTReSYmX8ojaxnnrVWKE7MNPqzo=; b=oNBFCqK3XUvL83iR/8ckI8evgx7wIh5r8dZ6Ef+hrbWEgySMc6qFfCyKJFE+zos7cRaDq5 3pZZs9XSCve/OKcvbm0PJmF5sumwl5eO6lU3XcbJHBNOaZYIGknatmmgkbL7YEJvbLaGPy BH857PEK6HXxX6UYN25HhJaI/9tqma0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697613425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sx+OF55aLjdy7xI7hTReSYmX8ojaxnnrVWKE7MNPqzo=; b=0beFQs2yepqpu+Kb+qL8JnQRjbXG6GKjn/zeriRzs9BrxS0VYNXmg2AW4AwEkxvnfAK56G 3KWxG1k2cqz0toBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1D1F13915; Wed, 18 Oct 2023 07:17:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u+hMJnGGL2XiXgAAMHmgww (envelope-from ); Wed, 18 Oct 2023 07:17:05 +0000 Message-ID: Date: Wed, 18 Oct 2023 09:17:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] [gdb/symtab] Fix style issues in v9 .gdb_index section support Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231011153214.25769-1-tdevries@suse.de> <87edhtqagu.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87edhtqagu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -6.99 X-Spamd-Result: default: False [-6.99 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.90)[99.58%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/23 22:07, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Post-commit review pointed out a few style issues in commit 8b9c08eddac > Tom> ("[gdb/symtab] Add name_of_main and language_of_main to the DWARF index"). > > Tom> Fix these. > > Tom> Tested on x86_64-linux. > > Thank you, this looks good. > Approved-By: Tom Tromey > > I found a race in this code as well, I'm working on a fix for that though. Thanks for the reviews, pushed. I was curious, so I build gdb with thread sanitizer and ran the test-suite with target board cc-with-gdb-index, and ran into a write-write data race for: ... cu->per_cu->dw_lang = dw_lang; ... for for instance test-case gdb.ada/catch_ex_std.exp. I suppose that's the race you're referring to. Thanks, - Tom