From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111082 invoked by alias); 23 Nov 2017 17:29:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108696 invoked by uid 89); 23 Nov 2017 17:29:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 17:29:06 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE3232CE913; Thu, 23 Nov 2017 17:29:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFA9C5D6A5; Thu, 23 Nov 2017 17:29:02 +0000 (UTC) Subject: Re: [PATCH v2] Add support for the --readnever command-line option (DWARF only) To: Sergio Durigan Junior References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <87o9ntddb6.fsf_-_@redhat.com> <2cb6d01b-b40b-0a73-2df4-65f4e2094731@redhat.com> <87efoodi79.fsf@redhat.com> Cc: Yao Qi , Joel Brobecker , "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Thu, 23 Nov 2017 17:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87efoodi79.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00566.txt.bz2 On 11/23/2017 05:21 PM, Sergio Durigan Junior wrote: >>> +This option is currently limited to debug information in DWARF format. >>> +For all other format, this option has no effect. >> >> How hard would it be to just make it work? There's only stabs and mdebug >> left, I think? There should be a single a function somewhere that we can >> add an early return. And then we don't need to document this limitation... >> >> For example, in elf_symfile_read, we could just skip the elf_locate_sections >> call. In coffread.c we could skip reading stabs right after >> bfd_map_over_sections (abfd, coff_locate_sections....); >> >> Looking for: >> >> $ grep -h "^[a-z]*_build_psymtabs" gdb/ >> coffstab_build_psymtabs (struct objfile *objfile, >> elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect, >> stabsect_build_psymtabs (struct objfile *objfile, char *stab_name, >> mdebug_build_psymtabs (minimal_symbol_reader &reader, >> elfmdebug_build_psymtabs (struct objfile *objfile, >> >> finds all the relevant places. >> >> Maybe it wouldn't be that hard to make this be an objfile flag >> afterall (like OBJF_READNOW is). That'd make it possible >> to add the location "-readnever" counterpart switch to add-symbol-file >> too, BTW: I meant "logical" instead of "location". I was staring at gdb/location.c at that time. :-P >> >> symfile.c: if (strcmp (arg, "-readnow") == 0) >> symfile.c: else if (strcmp (arg, "-readnow") == 0) > > Hm, I'll look into this. Just to make it clear: the idea is to have > both a --readnever global option and also a OBJF_READNEVER specific to > each objfile? Sure, the idea is to do something similar to what's done for --readnow. Thanks, Pedro Alves