From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Q0/O=5C=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 6196C3858D35
	for <gdb-patches@sourceware.org>; Thu,  5 Jan 2023 09:04:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6196C3858D35
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 9BCA86BB7B;
	Thu,  5 Jan 2023 09:04:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1672909483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mlaI1ksYBOzNp5A7EBr3oWkmarY/j0z+yEKl2WtZs0c=;
	b=SbAF45EqTYUAxU1FoIF9rfD2vTOc773eNdw/FMFa0eD/H9OSivixt1d3cabZtpbF6jLJS9
	E8XFLum45Hu6IVHo4iXB4mEslfHGAG6AQMZRA+TCilIbyQsVC77wfHrPX+2qj+QFG3KuQR
	4Hu7a5fyOz5K/XdEavG6JYGUXLgWi9I=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1672909483;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mlaI1ksYBOzNp5A7EBr3oWkmarY/j0z+yEKl2WtZs0c=;
	b=1iVq66nIwB/c7dK5YhPZpOv+CWtVaofpCQh1Qd9s4SZ1TdXGxnImuEmELBr8oMqRcSPGoc
	d10FxZNVa8Wfv+Dg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 892A713273;
	Thu,  5 Jan 2023 09:04:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id rVo2IKuStmMfLQAAMHmgww
	(envelope-from <tdevries@suse.de>); Thu, 05 Jan 2023 09:04:43 +0000
Message-ID: <ff5f8aaa-613a-9a2c-2c1a-360a1ea7ed0b@suse.de>
Date: Thu, 5 Jan 2023 10:04:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint
Content-Language: en-US
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20230103192216.108444-1-simon.marchi@polymtl.ca>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <20230103192216.108444-1-simon.marchi@polymtl.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 1/3/23 20:22, Simon Marchi via Gdb-patches wrote:
> -	-re "$gdb_prompt $" {
> -		if { $print_fail } {
> -			fail $test_name
> -		}
> -		return 0
> -	}

This caused:
...
FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: gdb_breakpoint: set 
breakpoint at 1
FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: 
!$breakpoint_at_missing_lineno_set
FAIL: gdb.go/methods.exp: going to first breakpoint (the program exited)
FAIL: gdb.go/methods.exp: going to second breakpoint (the program is no 
longer running)
...

Re-inserting this piece of code fixes it.

Thanks,
- Tom