From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 4/4] Remove interp_name
Date: Fri, 25 May 2018 19:36:00 -0000 [thread overview]
Message-ID: <ff61a2de-9417-ed86-a6b0-d3f0e7da0113@redhat.com> (raw)
In-Reply-To: <874liv1st7.fsf@tromey.com>
On 05/25/2018 07:41 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Not sure. The name is supposedly read-only, which would
> Pedro> suggest renaming the field to m_name and adding a name()
> Pedro> getter. WDYT?
>
> How about the appended as a follow-up patch to this series?
Thanks, looks good.
Pedro Alves
next prev parent reply other threads:[~2018-05-25 18:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 5:12 [RFA 0/4] minor interp-related cleanups Tom Tromey
2018-04-30 5:12 ` [RFA 4/4] Remove interp_name Tom Tromey
2018-05-25 18:41 ` Pedro Alves
2018-05-25 18:47 ` Tom Tromey
2018-05-25 19:36 ` Pedro Alves [this message]
2018-04-30 5:12 ` [RFA 3/4] Remove interp_ui_out Tom Tromey
2018-05-25 18:37 ` Pedro Alves
2018-04-30 5:12 ` [RFA 1/4] Use scoped_restore in a couple of interp-related places Tom Tromey
2018-05-25 18:06 ` Pedro Alves
2018-04-30 5:12 ` [RFA 2/4] Change the as_*_interp functions to use dynamic_cast Tom Tromey
2018-05-25 18:12 ` Pedro Alves
2018-05-25 17:34 ` [RFA 0/4] minor interp-related cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff61a2de-9417-ed86-a6b0-d3f0e7da0113@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).