From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id D79A2385840C for ; Wed, 14 Feb 2024 15:39:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D79A2385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D79A2385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925170; cv=none; b=rqJ+IknlcYT8JdBTSnazXJINs3OkadU8b9uXVOnegUYTRJjyiGpwHVpPXsHVowK7ekTiRydD6yEa/4oCCWd0RKFPKvG67teqUxglykDH9G7aQBqFxf7+LKZsHn1WcJsVDiMwA33rDtKUAraRjPtspWya5oJpGa91RekQCpQ+0KA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925170; c=relaxed/simple; bh=QHBfjnw+037JTneyqwtP+jkZPOprhJ4Wse5Whq4zLA8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=flA7qYs8S370ti9QBvpu/kZDGKoeUEg3rbhHgbLELn4sdOKh8mI3BfTeTttoqEZvpE3KIj0VpKF9LAxEZkbEUPUJ7JPLK0KXyQ3LWOXWPwQLysUUoW8BOZj1iVFM7Izwd63jQADBe/OxBnCWSNv9+8XBFpemHt5cinwUcTmyYQc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8B991F801; Wed, 14 Feb 2024 15:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707925168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+g5WhOdjcrI8fxMJB6nidlJ3MzlWrIDoBe9YIJPKt8=; b=ffy8Vo/fwt+7R6dY3GUI4VHTfJfNYNgGLmiGqaIYFuj8fYod1rsguuBYg7ajmDJXMfW+mP 3SDPAG0oMP4Ife5LF0JbmejLO5jbynpe6J7ZUoceK1VRyKzPitwccGbgnvqXcRMRyF3ksx JQJJ2LiEOgGXiSJGQRrSbQ2oOugE6O4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707925168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+g5WhOdjcrI8fxMJB6nidlJ3MzlWrIDoBe9YIJPKt8=; b=TU5GJxQzpbrW7VcN8DEfZygFDmqXvI0MBUG0oavoYHe1bdNqnXoBtRkreCdz/4mUiQRv13 iuqWgs5om9Yl2kBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707925167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+g5WhOdjcrI8fxMJB6nidlJ3MzlWrIDoBe9YIJPKt8=; b=qNyIDjgvrtMKOAJ0VmUhd3Y03k0qArk50p1EmLnuZT6VZvpnqTEw5QG3v87165xXTx1sKk 7wmmVLhySSH/+UVXJR8TrsLzylPFbYcEOi51vGu3H0kmwdBnLyJKKohP0FJjy3QrusbksQ fvcY8MrNiLr3lQwV10bkrzIntNkmFJI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707925167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+g5WhOdjcrI8fxMJB6nidlJ3MzlWrIDoBe9YIJPKt8=; b=CklUDAwBNinToLObJbxQjGq3Yj5vbyynzS06g5hzcuCo/zcoq+vU2vnSjladifWNV91L8v u1Y6miv78zqz1XAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D1BAC13A6D; Wed, 14 Feb 2024 15:39:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FSLIMa/ezGWRKgAAD6G6ig (envelope-from ); Wed, 14 Feb 2024 15:39:27 +0000 Message-ID: Date: Wed, 14 Feb 2024 16:39:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/dap] Fix exit race Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240213150141.28034-1-tdevries@suse.de> <87a5o45j77.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87a5o45j77.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qNyIDjgv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CklUDAwB X-Spamd-Result: default: False [-3.90 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.10)[95.62%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: E8B991F801 X-Spam-Level: X-Spam-Score: -3.90 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/13/24 19:10, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Fix this by removing the send_gdb("quit"). > > I thought you were sending a different patch for this? This is the patch for PR31306, the assertion failure. > I think this change by itself is insufficient because it might mean that > gdb exits before all the queued responses are emitted. As for PR31380, which is about ensuring responses are flushed to client before exiting, indeed there's a race between flushing the write queue and gdb exiting because of a SIGHUP (which is not caused by the send_gdb("quit"), I've mentioned that in the PR. Thanks, - Tom