From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id AF3C83858C56 for ; Fri, 12 Apr 2024 20:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF3C83858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF3C83858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712952748; cv=none; b=K7MUkV7xfnovTXhFgqvkwbXeGJTLDGgikGeqVIA09dz8TYnPSMonJzCrwDmFf+PWOGLoDQ2EJ7Ofm/4YBfntiYHe7pCGR6dz2/l8po1erudLxqnWiGBrfVrkIbEZ5BI4Q9HHc+SCZ7LN23vZKV2WWP4y8IMSKwkRcPyka4PfXVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712952748; c=relaxed/simple; bh=4LnmGo7un0FD8GWvnWOgkHEDrrC0Nmp/pGFx84Cz+No=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=UHFus7DYVu2YxzO25L5/JkO+ePO7wgDXY2O8kR1NvEaxAEnUY3JbnZLgQEjlVcBMYFmDwEdOORPMgRnLCwJ6pAbDLHdPPXxOihpPFl/K8pncL8b3sISpjLJoOQJ1p27+BR6lCFcWobXuGMVdPTruUf0wAaaEIGfID1OyQYjbuaI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 718481F8B9; Fri, 12 Apr 2024 20:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712952744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3noLy1fuifLBkB2pxnbVYQHEipOQgDfv/OjOSHyY7wc=; b=srzMyj9o1A8o3cbsa/GvHuB2d/U7Z0QeNkNvIPTLqFCQEiyei0wGjLK9u0UVsA/9LTNnG8 +8CPV+do4AbWoI2zj7sBJBnzlC7PBnqYMfF7Umv+Av1blCJHalHvtt0qG+FJoFKp0RO+Uy hJmJziM849+o0+9R1TNY/h6rNOqP3+M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712952744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3noLy1fuifLBkB2pxnbVYQHEipOQgDfv/OjOSHyY7wc=; b=z8H+ksxk4vCoZa3ZdSwc1buFO5WVpJVF+zF+HzjQ1ifavmoF424ldc4XS0lHCowMkEvJBG u5t9HrrTOtnHHoDA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=srzMyj9o; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=z8H+ksxk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712952744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3noLy1fuifLBkB2pxnbVYQHEipOQgDfv/OjOSHyY7wc=; b=srzMyj9o1A8o3cbsa/GvHuB2d/U7Z0QeNkNvIPTLqFCQEiyei0wGjLK9u0UVsA/9LTNnG8 +8CPV+do4AbWoI2zj7sBJBnzlC7PBnqYMfF7Umv+Av1blCJHalHvtt0qG+FJoFKp0RO+Uy hJmJziM849+o0+9R1TNY/h6rNOqP3+M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712952744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3noLy1fuifLBkB2pxnbVYQHEipOQgDfv/OjOSHyY7wc=; b=z8H+ksxk4vCoZa3ZdSwc1buFO5WVpJVF+zF+HzjQ1ifavmoF424ldc4XS0lHCowMkEvJBG u5t9HrrTOtnHHoDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 53B391377F; Fri, 12 Apr 2024 20:12:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id s4qhEqiVGWaAVgAAD6G6ig (envelope-from ); Fri, 12 Apr 2024 20:12:24 +0000 Message-ID: Date: Fri, 12 Apr 2024 22:12:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] gdb: Support embedded source in DWARF To: Will Hawkins , gdb-patches@sourceware.org References: <20240412185525.171292-1-hawkinsw@obs.cr> Content-Language: en-US From: Tom de Vries In-Reply-To: <20240412185525.171292-1-hawkinsw@obs.cr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-2.60 / 50.00]; BAYES_HAM(-1.10)[88.21%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; XM_UA_NO_VERSION(0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 718481F8B9 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -2.60 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 20:55, Will Hawkins wrote: > + DW_LNE_set_address main_end > + line [gdb_get_line_number "main end"] > + DW_LNS_copy > + > + DW_LNE_end_sequence > + } I've just submitted a patch series designed to catch this ( https://sourceware.org/pipermail/gdb-patches/2024-April/207922.html ). The copy produces a line table entry with empty address range (because the end_sequence is at the same address),. This is probably not what you intended. Thanks, - Tom