From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2052.outbound.protection.outlook.com [40.107.116.52]) by sourceware.org (Postfix) with ESMTPS id E356D3858C52 for ; Tue, 17 Oct 2023 15:32:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E356D3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E356D3858C52 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.52 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697556742; cv=pass; b=Byh1X6XJu4C7Wjs6HMUq2sPuCpGiM8BAeh8K6IrqFF4ya8lV/Rp6fS2Xv2lJ+I31SnGj7LTc8qfcgq/YH3z1j0SCxGP5OFY54/FxpkiOfIYrtQPSTaQtCaCSqm8lG+fAWroXPj/PDC2UD8jaF5leyrn0yxb0uwriUiaRVr1VUcw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697556742; c=relaxed/simple; bh=WZpzi5dmrqnj2hckRJh9Djn7vxMrZffBj3D5k/HC/54=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=jxPh7YmD1pwPWXSsmiHU6WGToy2PAAy7ktXLhy0zBYghE9f28jaU4cfxUvweqYtVzpqpIU2/VbqrdgMa9cl5G8yzobzKRPdu35Lo5Ay2ApVuB6y9WmZyJpau5YG19QY8l81ZQUl7kwAA22/i3sAvmhw9hi71A5VpkcGPGQipiIk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0uf9AYi1e0yNJH4gwmPPgskX1f8bC7QvXZgsqFyyCVyMzcYN9kymtJ4HehtUfTYbiJYuE1FK55VU+6XDKxIKdlOVC2O6Gu7WVq7Mkami6OGqxz9br5WJqtXuXbo0qOiSqoRk1GChZWSVmhAng1Zbg622k1P5ghP8YAmZNBV1sXBB84dYNsGneC0uibOH2yTnrAByuCUvCausOzO8O6jsoz9oqnH5nrGbtQr7yFM0MpEpekDG2PRjoncU8chtIXqGZpNrR5PtlXXiDgLMv7wcpA4IipxNfe37JY/s6w8tslvq2dOydhlr0H9N9eo9BaawRJ5/XaPE8R+9T17uVwGMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rBw+XIraS+mqen4OmClmodOr7maM7tzyeLqTuqkyTqk=; b=mU+0iAFm/wXSwEIjagMJgjiYoDPJJnnPIr9u76lXdfWisaKijNs9LMdrlGoxq6Qi/uXti8mMT2dQA/W3KN25sHX+v5CXbs9w6z4wYFHWst1bOI/HbPADgKwdbiB8MXZYC2UUCRlftfwQSiqKClS+lWqzyGmW6dwYabmWc3V7d1rEubuqOexZ+CP6CqcTFE705zCmcqumhXIJoHm6sQ8CoSMP17YIVGKQL6KDiOu7PRPf9w3yIAr9S9hoR5B6bcQqZQEkE7DVXxcoGBYUeZiNUmJuC8um4yy09pkF04+JKhN1qCZWFPs0rLly0YIwj/PkPVHASum2GtM5ITBt17Or4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBw+XIraS+mqen4OmClmodOr7maM7tzyeLqTuqkyTqk=; b=SfJ5lhrZJxzqXd4ufTxnDFWxldhhCe0WlSb7UoZxr8QqfHfCh8ld2Pj4yURp3JMXOf7dHwOEWveSIyXoLZqKrNEea+g5uovMykpvyJsl1idlKE7Qgpy/TeSSyrR6msL/L4dLvi/J+yN89GAtvBCvcqIwwvmAIARUHyvcD8xJyI/chknpJzRpMhEdZvRJ3gboAwp9+DnSmWDF2sWg47vzbbF0EPxsiLO6D1csnmQoZS9V7z0wEpduZwyLIiGpluw+2rouKM+Z3vgvWqxm7QM/WqGpgI+XDeH7nMn3GqWRpAtx5hn9/jQ7C8vGMlCLWH84RbrHPe+OUi55cdNiHZGZ1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB8932.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:7e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 15:32:18 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6907.021; Tue, 17 Oct 2023 15:32:18 +0000 Message-ID: Date: Tue, 17 Oct 2023 11:32:15 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/24] gdb: make solib-rocm not use so_list internally Content-Language: fr To: Pedro Alves , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-14-simon.marchi@efficios.com> <523ea38d-d363-4ee7-8506-304cdf979f6e@palves.net> From: Simon Marchi In-Reply-To: <523ea38d-d363-4ee7-8506-304cdf979f6e@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0124.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:87::14) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB8932:EE_ X-MS-Office365-Filtering-Correlation-Id: b9a4513f-37a1-4397-105d-08dbcf263f5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yijhkWrYh8Iaj7Kdwo1VDfONUGTxwZIMWVSjlMALbh68vJrH4CITX3QkVtK4Ddr0b4m8+i+MvOqpEuxQwUCYplkC8butOWOzlcZkODIi0vc284AruDcoMVuStD27J/5ugW6OcyX8l7f7GkMEDQbbh40p2YtYWRT/H6i+G3E5HO3dzErCaVRe3JSkWI21A5J9oru/vzb6db5Tv6qq4+va5mplyx8h5jMo+RrYqeIRGCaHjd50AAYoL0OYz+QUjnD1DBvAiA9Fe/XlMFS7ZQdomt2tWyexASLRS/LVPzWI3AixGrIfi7QTarleeaZL666jSVnIHLZV8eyagldTjpv3PcR/YVOlIBaEOe/hLK6F2i0tUBqU3DyQUSS8F5tOHGYp7FALhNhAvFUXjPnxP8ggjfR+7NhJxjGQ55QXERTE4ZXMXACMjTYVHQQBk9M2L+uMS26sDYQqixRvkjljAqGhshG3WWXmzpp1wKtqaQX1DJsq/Nsh6HYOgHjW8cZJ4EoX/VeaAknqHwerD/wHmibAuC2TzPXya8UrxpmYWiq4gGJYP6drWJiByvO/os2WRmSN5DQcQfxLCuZtC6iMDCtypmWztu/kNsSMkfhGRXV6xDZBlFz36xzoK1UI6VNmLG44CazfReR1UmGvDFAvhp37iQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(39830400003)(376002)(346002)(366004)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(53546011)(83380400001)(26005)(8676002)(5660300002)(41300700001)(8936002)(44832011)(2616005)(36756003)(31696002)(31686004)(6486002)(2906002)(4744005)(4001150100001)(478600001)(66946007)(66476007)(66556008)(316002)(6506007)(6512007)(6666004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjVjQys0TG1rcTdSbzAzTzZlL1c4b1JHRWk3TFJpZ21sdlpzUjMzNGJPZ0ZQ?= =?utf-8?B?QWRhT3NsZzVuTXFpUWFwNkVJSk5YL3o4RVM3SDQvTUpMbmpWK1lsYmg0SUI5?= =?utf-8?B?SnB2bkF4cTMyRWU4Vk9lV3lSVzE5VGlaVXhLYk1ZSlFBYXZHekxlRzh5NU9n?= =?utf-8?B?WkdteXNITnRhMmRIL2Myb0xpZW1pR3kvTlMrMW13RjF4OGtCRWJSNHhmV3dp?= =?utf-8?B?N0lJQkUwUDVNZlFkalJBOVRuelF6WXBhR2RTTzdCcXZSeTYrc0FNWnhySEdW?= =?utf-8?B?cDlVcGJyVjNvWkFKWlp3ZGZkc2NYYWl1VUxzQlRnUXNyRUFsVHVoV0RGTDJQ?= =?utf-8?B?Z2tuYnhnNFJja09qRXcrU0djVUhJL0x4LzNxUklsNWRkZHQvMkdRMXh3czM0?= =?utf-8?B?Y2RpU1ZHa3pPZlJFWng3RktLTEUwajRWNUozenVTYS9UVU9JTUgrS3VGc2g5?= =?utf-8?B?K1I2dGpybytpQWU2N2ZITFN6cDFYOUN3c1FsemVNYkNIdjY2c2EvUVFpS1Zk?= =?utf-8?B?TjB3UGdzM3dhR3VoeHk4cU5hRCt3dGRrRllpcGtvRWhmZzZiWnRkdUE2UWEy?= =?utf-8?B?ZjRkWCtqek12eU0vMTRrWWZUTnU0Z090aUpZbHQyUDZNQXAyK2ZUR2ZBVkJW?= =?utf-8?B?SjJONm9CZTNaejlIZGJnRmN4ekwzRjVYaWMrUENJSkJNdkozMGVVNEE4Q2Mv?= =?utf-8?B?dE1XZ1htQ0VZMG9ZVTUyRDdzY2U3Y2I0NlRrU2dLSGZrMUNsZjJNeEQrUFg5?= =?utf-8?B?V0ZkRGZKQVFjWm1VZkdZbUNKSG5uT2YreHMrQU94QjcwdzBEc3hsc3VOQ1pv?= =?utf-8?B?UWdvTWFWbVVHejE2c3NlcGE0VTZ0b250YzZGaGp0ZjBlRzlTZGlLS3hPM0VK?= =?utf-8?B?Wk5mTU5HMmJFUXI0SVdzdnZtS0R1MW56djlFM2lqaW5TTFdMMDgzN2lKZVJn?= =?utf-8?B?QmNVVUZnOUJLNDNPdGZsaG1UdDFqUmZoeEJzTmZ0N3BDUkFzTkpwV1B3RlVO?= =?utf-8?B?OHhmclUzd1hONHJIY0p6M3RhbFFINFBiYk9tUnl5alVSdjVITzI1b1VwZFg1?= =?utf-8?B?QU85c0pRTHdDY2Q5UXR2TEVYaGVoTHFjZ2VZb1hwTUZMTjY1akthWFM4R2tm?= =?utf-8?B?OWROZlY0QUJMcHdnWWtqZ0ZrcTN4K0V4Vks1dWFuc2piQ3ZQdUtpVHZ3NEU5?= =?utf-8?B?NmRwaEpubU5POXFmdTRNYnNQVTFFb1VMUmVxbVN2U0toWWh4RTZGZlBQbzY5?= =?utf-8?B?Smd3NnE3TWk1c0RLbkVGejh2aGJOMXhheHFxTGhYamYyTlFpUTMvSWRpK2xa?= =?utf-8?B?L1VXdjdxd3dzZlBHNHA2RndHQWJKbTMvUGdOYWpXWlVuM0dkQjFEMzZTRkw0?= =?utf-8?B?RXF5L0hQVkNSaVZHV2FxWC9XdkZzSkpQaTJiOHRtZlU3ZlpnSHR3UTFzaVdi?= =?utf-8?B?VWUxMkpxdFBiOFdmUVVDakptZFlFNElYTTJtQU1KWlhSVE1BNG5wcEZ3NkZq?= =?utf-8?B?dVpUVFNlWnROQ01nYUtIdGRwK2JyclNjRTFhNDlmdU1UOG92dTE4dnJna2Rn?= =?utf-8?B?NWtCZG80N3dPUjlKamxkbkFWVVFlWmxYYlUvOFhTMElrSE1lR0JZWGRkbkVV?= =?utf-8?B?VndoSW5MSlg3VHpSZExyd2E3c3NsMHlsYnVRSTY2dUZlVWxRSGlMQjFIa29D?= =?utf-8?B?U202MWdHYy9NWUE3RUk0VDFyV1JyQ0JESmVpekhqYkxTWVpVQjVxQzlnUGRi?= =?utf-8?B?a0lmUzFsU2ExWVhWMkFoTkY0NUc3dk9temZ2ZGxDMGljRnNvQTFNUnhlWGRa?= =?utf-8?B?ZnJRcWNoaURUM0gxWHBZKzd4MkFnbklaV2U3SjdneXp2NnhUR0hPTUZtZDB2?= =?utf-8?B?VGt3QmROS29HT0RDWVdQOWJ2KzJpZ2F5aVlFQld2dmFCeUpJWmxFM2R4YWlV?= =?utf-8?B?U0F5Y3pGUWpTbjMra0dUYWlRRnF2QitXdEV5a3hMTHcydS9nVmlOZU02a09O?= =?utf-8?B?d3FtWWxzdVlQWU0xMjNXTEVaOHJmQkQvZ3dhTnVCK1ZCVGpvQnRaeXZJZE5C?= =?utf-8?B?YkVaZm4vWjluWSszbmp1V1hNTjNsK2U4Zkg2b3J6Y2NPZG5RYWRsL3dDRVdu?= =?utf-8?Q?KnNp6pj+L6FRzp0sQlQae1fxN?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9a4513f-37a1-4397-105d-08dbcf263f5d X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:32:18.3862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +GGINR2++5VoEgFvB2HKhe0aP25GZVW/WMdjI7CHLg2w5XqDeyTSj09AfTsIf7L3aO8gtYnOtMpTW8LEd+T+JQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8932 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/23 11:23, Pedro Alves wrote: > On 2023-10-10 21:40, Simon Marchi wrote: > >> --- a/gdb/solib-rocm.c >> +++ b/gdb/solib-rocm.c >> @@ -126,14 +126,26 @@ rocm_solib_fd_cache::close (int fd, fileio_error *target_errno) >> >> /* ROCm-specific inferior data. */ >> >> +struct rocm_so >> +{ >> + rocm_so (const char *name, std::string unique_name, lm_info_svr4_up lm_info) >> + : name (name), >> + unique_name (std::move(unique_name)), > > Space after "move". > Thanks, fixed locally. Simon