From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Handle .gdb_index in ada language mode
Date: Wed, 10 Jun 2020 14:49:47 +0200 [thread overview]
Message-ID: <ffdea206-5ebf-f429-0c04-4ffb98245c5f@suse.de> (raw)
In-Reply-To: <2795c8df-ab53-463a-5b2a-d3acf3f2ce31@suse.de>
On 02-06-2020 12:47, Tom de Vries wrote:
> On 22-05-2020 22:31, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Using this patch, I managed to get it working.
>>
>> Wow, cool.
>>
>> Tom> The patch does the following:
>> Tom> - enable ada .gdb_index by removing the ada check in write_psymbols
>> Tom> - copy some ada-specific code from debug_names::insert to
>> Tom> write_psymbols
>> Tom> - disable a workaround for gold/15646 in dw2_expand_marked_cus
>>
>> Tom> As for the disabled workaround, I ran into trouble in
>> Tom> gdb.ada/access_tagged_param.exp, where setting a breakpoint on foo failed.
>>
>> Tom> The index shows that there are two entries for foo, one variable, one
>> Tom> function:
>> Tom> ...
>> Tom> [3733] foo:
>> Tom> 3 [global, variable]
>> Tom> 5 [global, function]
>> Tom> ...
>> Tom> The workaround skips the function, so disabling the workaround allows
>> Tom> the test to pass (my guess atm is that the workaround is not precise
>> Tom> enough).
>>
>> Looking at the gold bug, I suspect what's needed is to rule out
>> duplicates that have the same kind.
>>
>
> The workaround has been limited:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f030440daa989ae3dadc1fa4342cfa16d690db3c
> .
>
>> I tend to think you should push your previous patch, and maybe we can
>> revisit this stuff later.
>>
>> Tom> + std::string decoded = ada_decode (name);
>> Tom> + if (decoded[0] == '<')
>> Tom> + name = (char *) strndup (decoded.c_str () + 1, decoded.length () - 2);
>> Tom> + else
>> Tom> + name = strdup (ada_encode (decoded.c_str ()));
>> Tom> + }
>>
>> This leaks the string.
>
> Fixed in a new version of the patch, submitted as part of patch series:
> - "[PATCH, 1/2][gdb/symtab] Fix name lookup in dw2_map_matching_symbols"
> https://sourceware.org/pipermail/gdb-patches/2020-June/169213.html
> - "[PATCH][gdb/symtab] Enable ada .gdb_index"
> https://sourceware.org/pipermail/gdb-patches/2020-June/169214.html
>
> [ Note the missing ", 2/2" in subject of second patch. ]
I've committed these two patches.
Thanks,
- Tom
prev parent reply other threads:[~2020-06-10 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 9:41 Tom de Vries
2020-05-19 20:32 ` Tom Tromey
2020-05-20 9:40 ` Tom de Vries
2020-05-22 20:31 ` Tom Tromey
2020-05-26 13:01 ` [PATCH][gdb/symtab] Make gold index workaround more precise Tom de Vries
2020-05-26 14:03 ` Tom de Vries
2020-05-27 15:22 ` Tom Tromey
2020-05-28 13:02 ` Tom de Vries
2020-05-27 15:21 ` Tom Tromey
2020-06-02 10:47 ` [PATCH][gdb/symtab] Handle .gdb_index in ada language mode Tom de Vries
2020-06-10 12:49 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdea206-5ebf-f429-0c04-4ffb98245c5f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).