* [review] Move _initialize_tui_layout to end of file
@ 2019-10-27 21:44 Tom Tromey (Code Review)
2019-11-06 14:27 ` [review v2] " Tom Tromey (Code Review)
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-27 21:44 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/362
......................................................................
Move _initialize_tui_layout to end of file
This moves _initialize_tui_layout to the end of the file, conforming
to the typical gdb style.
gdb/ChangeLog
2019-10-27 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (_initialize_tui_layout): Move to end.
Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
---
M gdb/ChangeLog
M gdb/tui/tui-layout.c
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e43f63c..9c79569 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-10-27 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (_initialize_tui_layout): Move to end.
+
+2019-10-27 Tom Tromey <tom@tromey.com>
+
* tui/tui-win.c (resize_message): New global.
(show_tui_resize_message): New function.
(tui_async_resize_screen): Print message if requested.
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 3a510f4..c7f6545 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -247,31 +247,6 @@
complete_on_enum (tracker, layout_names, text, word);
}
-/* Function to initialize gdb commands, for tui window layout
- manipulation. */
-
-void
-_initialize_tui_layout (void)
-{
- struct cmd_list_element *cmd;
-
- cmd = add_com ("layout", class_tui, tui_layout_command, _("\
-Change the layout of windows.\n\
-Usage: layout prev | next | LAYOUT-NAME\n\
-Layout names are:\n\
- src : Displays source and command windows.\n\
- asm : Displays disassembly and command windows.\n\
- split : Displays source, disassembly and command windows.\n\
- regs : Displays register window. If existing layout\n\
- is source/command or assembly/command, the \n\
- register window is displayed. If the\n\
- source/assembly/command (split) is displayed, \n\
- the register window is displayed with \n\
- the window that has current logical focus."));
- set_cmd_completer (cmd, layout_completer);
-}
-
-
/* Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA, or
REGS. */
static void
@@ -568,3 +543,29 @@
src_height);
current_layout = layout_type;
}
+
+\f
+
+/* Function to initialize gdb commands, for tui window layout
+ manipulation. */
+
+void
+_initialize_tui_layout (void)
+{
+ struct cmd_list_element *cmd;
+
+ cmd = add_com ("layout", class_tui, tui_layout_command, _("\
+Change the layout of windows.\n\
+Usage: layout prev | next | LAYOUT-NAME\n\
+Layout names are:\n\
+ src : Displays source and command windows.\n\
+ asm : Displays disassembly and command windows.\n\
+ split : Displays source, disassembly and command windows.\n\
+ regs : Displays register window. If existing layout\n\
+ is source/command or assembly/command, the \n\
+ register window is displayed. If the\n\
+ source/assembly/command (split) is displayed, \n\
+ the register window is displayed with \n\
+ the window that has current logical focus."));
+ set_cmd_completer (cmd, layout_completer);
+}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
Gerrit-Change-Number: 362
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review v2] Move _initialize_tui_layout to end of file
2019-10-27 21:44 [review] Move _initialize_tui_layout to end of file Tom Tromey (Code Review)
@ 2019-11-06 14:27 ` Tom Tromey (Code Review)
2019-11-12 16:07 ` Andrew Burgess (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-06 14:27 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/362
......................................................................
Move _initialize_tui_layout to end of file
This moves _initialize_tui_layout to the end of the file, conforming
to the typical gdb style.
gdb/ChangeLog
2019-11-06 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (_initialize_tui_layout): Move to end.
Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
---
M gdb/ChangeLog
M gdb/tui/tui-layout.c
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d23bd57..e66b957 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-11-06 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (_initialize_tui_layout): Move to end.
+
+2019-11-06 Tom Tromey <tom@tromey.com>
+
* tui/tui-win.c (resize_message): New global.
(show_tui_resize_message): New function.
(tui_async_resize_screen): Print message if requested.
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 3a510f4..c7f6545 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -247,31 +247,6 @@
complete_on_enum (tracker, layout_names, text, word);
}
-/* Function to initialize gdb commands, for tui window layout
- manipulation. */
-
-void
-_initialize_tui_layout (void)
-{
- struct cmd_list_element *cmd;
-
- cmd = add_com ("layout", class_tui, tui_layout_command, _("\
-Change the layout of windows.\n\
-Usage: layout prev | next | LAYOUT-NAME\n\
-Layout names are:\n\
- src : Displays source and command windows.\n\
- asm : Displays disassembly and command windows.\n\
- split : Displays source, disassembly and command windows.\n\
- regs : Displays register window. If existing layout\n\
- is source/command or assembly/command, the \n\
- register window is displayed. If the\n\
- source/assembly/command (split) is displayed, \n\
- the register window is displayed with \n\
- the window that has current logical focus."));
- set_cmd_completer (cmd, layout_completer);
-}
-
-
/* Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA, or
REGS. */
static void
@@ -568,3 +543,29 @@
src_height);
current_layout = layout_type;
}
+
+\f
+
+/* Function to initialize gdb commands, for tui window layout
+ manipulation. */
+
+void
+_initialize_tui_layout (void)
+{
+ struct cmd_list_element *cmd;
+
+ cmd = add_com ("layout", class_tui, tui_layout_command, _("\
+Change the layout of windows.\n\
+Usage: layout prev | next | LAYOUT-NAME\n\
+Layout names are:\n\
+ src : Displays source and command windows.\n\
+ asm : Displays disassembly and command windows.\n\
+ split : Displays source, disassembly and command windows.\n\
+ regs : Displays register window. If existing layout\n\
+ is source/command or assembly/command, the \n\
+ register window is displayed. If the\n\
+ source/assembly/command (split) is displayed, \n\
+ the register window is displayed with \n\
+ the window that has current logical focus."));
+ set_cmd_completer (cmd, layout_completer);
+}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
Gerrit-Change-Number: 362
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review v2] Move _initialize_tui_layout to end of file
2019-10-27 21:44 [review] Move _initialize_tui_layout to end of file Tom Tromey (Code Review)
2019-11-06 14:27 ` [review v2] " Tom Tromey (Code Review)
@ 2019-11-12 16:07 ` Andrew Burgess (Code Review)
2019-11-12 19:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 19:40 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Burgess (Code Review) @ 2019-11-12 16:07 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/362
......................................................................
Patch Set 2: Code-Review+2
LGTM
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
Gerrit-Change-Number: 362
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 16:07:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Move _initialize_tui_layout to end of file
2019-10-27 21:44 [review] Move _initialize_tui_layout to end of file Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-11-12 19:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-12 19:40 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-12 19:40 UTC (permalink / raw)
To: Tom Tromey, Andrew Burgess, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/362
......................................................................
Move _initialize_tui_layout to end of file
This moves _initialize_tui_layout to the end of the file, conforming
to the typical gdb style.
gdb/ChangeLog
2019-11-12 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (_initialize_tui_layout): Move to end.
Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
---
M gdb/ChangeLog
M gdb/tui/tui-layout.c
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ee9a464..f1a05e2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-11-12 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (_initialize_tui_layout): Move to end.
+
+2019-11-12 Tom Tromey <tom@tromey.com>
+
* tui/tui-win.c (resize_message): New global.
(show_tui_resize_message): New function.
(tui_async_resize_screen): Print message if requested.
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 3a510f4..c7f6545 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -247,31 +247,6 @@
complete_on_enum (tracker, layout_names, text, word);
}
-/* Function to initialize gdb commands, for tui window layout
- manipulation. */
-
-void
-_initialize_tui_layout (void)
-{
- struct cmd_list_element *cmd;
-
- cmd = add_com ("layout", class_tui, tui_layout_command, _("\
-Change the layout of windows.\n\
-Usage: layout prev | next | LAYOUT-NAME\n\
-Layout names are:\n\
- src : Displays source and command windows.\n\
- asm : Displays disassembly and command windows.\n\
- split : Displays source, disassembly and command windows.\n\
- regs : Displays register window. If existing layout\n\
- is source/command or assembly/command, the \n\
- register window is displayed. If the\n\
- source/assembly/command (split) is displayed, \n\
- the register window is displayed with \n\
- the window that has current logical focus."));
- set_cmd_completer (cmd, layout_completer);
-}
-
-
/* Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA, or
REGS. */
static void
@@ -568,3 +543,29 @@
src_height);
current_layout = layout_type;
}
+
+\f
+
+/* Function to initialize gdb commands, for tui window layout
+ manipulation. */
+
+void
+_initialize_tui_layout (void)
+{
+ struct cmd_list_element *cmd;
+
+ cmd = add_com ("layout", class_tui, tui_layout_command, _("\
+Change the layout of windows.\n\
+Usage: layout prev | next | LAYOUT-NAME\n\
+Layout names are:\n\
+ src : Displays source and command windows.\n\
+ asm : Displays disassembly and command windows.\n\
+ split : Displays source, disassembly and command windows.\n\
+ regs : Displays register window. If existing layout\n\
+ is source/command or assembly/command, the \n\
+ register window is displayed. If the\n\
+ source/assembly/command (split) is displayed, \n\
+ the register window is displayed with \n\
+ the window that has current logical focus."));
+ set_cmd_completer (cmd, layout_completer);
+}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
Gerrit-Change-Number: 362
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Move _initialize_tui_layout to end of file
2019-10-27 21:44 [review] Move _initialize_tui_layout to end of file Tom Tromey (Code Review)
2019-11-06 14:27 ` [review v2] " Tom Tromey (Code Review)
2019-11-12 16:07 ` Andrew Burgess (Code Review)
@ 2019-11-12 19:40 ` Sourceware to Gerrit sync (Code Review)
2019-11-12 19:40 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-12 19:40 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Andrew Burgess
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/362
......................................................................
Move _initialize_tui_layout to end of file
This moves _initialize_tui_layout to the end of the file, conforming
to the typical gdb style.
gdb/ChangeLog
2019-11-12 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (_initialize_tui_layout): Move to end.
Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
---
M gdb/ChangeLog
M gdb/tui/tui-layout.c
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ee9a464..f1a05e2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-11-12 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (_initialize_tui_layout): Move to end.
+
+2019-11-12 Tom Tromey <tom@tromey.com>
+
* tui/tui-win.c (resize_message): New global.
(show_tui_resize_message): New function.
(tui_async_resize_screen): Print message if requested.
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 3a510f4..c7f6545 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -247,31 +247,6 @@
complete_on_enum (tracker, layout_names, text, word);
}
-/* Function to initialize gdb commands, for tui window layout
- manipulation. */
-
-void
-_initialize_tui_layout (void)
-{
- struct cmd_list_element *cmd;
-
- cmd = add_com ("layout", class_tui, tui_layout_command, _("\
-Change the layout of windows.\n\
-Usage: layout prev | next | LAYOUT-NAME\n\
-Layout names are:\n\
- src : Displays source and command windows.\n\
- asm : Displays disassembly and command windows.\n\
- split : Displays source, disassembly and command windows.\n\
- regs : Displays register window. If existing layout\n\
- is source/command or assembly/command, the \n\
- register window is displayed. If the\n\
- source/assembly/command (split) is displayed, \n\
- the register window is displayed with \n\
- the window that has current logical focus."));
- set_cmd_completer (cmd, layout_completer);
-}
-
-
/* Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA, or
REGS. */
static void
@@ -568,3 +543,29 @@
src_height);
current_layout = layout_type;
}
+
+\f
+
+/* Function to initialize gdb commands, for tui window layout
+ manipulation. */
+
+void
+_initialize_tui_layout (void)
+{
+ struct cmd_list_element *cmd;
+
+ cmd = add_com ("layout", class_tui, tui_layout_command, _("\
+Change the layout of windows.\n\
+Usage: layout prev | next | LAYOUT-NAME\n\
+Layout names are:\n\
+ src : Displays source and command windows.\n\
+ asm : Displays disassembly and command windows.\n\
+ split : Displays source, disassembly and command windows.\n\
+ regs : Displays register window. If existing layout\n\
+ is source/command or assembly/command, the \n\
+ register window is displayed. If the\n\
+ source/assembly/command (split) is displayed, \n\
+ the register window is displayed with \n\
+ the window that has current logical focus."));
+ set_cmd_completer (cmd, layout_completer);
+}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I667f741b44b2bc470878a36f093a96d89fa31893
Gerrit-Change-Number: 362
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-12 19:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-27 21:44 [review] Move _initialize_tui_layout to end of file Tom Tromey (Code Review)
2019-11-06 14:27 ` [review v2] " Tom Tromey (Code Review)
2019-11-12 16:07 ` Andrew Burgess (Code Review)
2019-11-12 19:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 19:40 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).