public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Subject: [review] Remove some globals from windows-nat.c
Date: Tue, 29 Oct 2019 18:05:00 -0000	[thread overview]
Message-ID: <gerrit.1572371871000.I44f3d150deefc9046ddcdc7321a8989bc4f7a16a@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572371871000.I44f3d150deefc9046ddcdc7321a8989bc4f7a16a@gnutoolchain-gerrit.osci.io>

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/424
......................................................................

Remove some globals from windows-nat.c

windows-nat.c has a few "count" globals that don't seem to be used.
Possibly they were used for debugging at some point, but they no
longer seem useful to me.  Because they get in the way of some code
sharing, this patch removes them.

Change-Id: I5e0553eb0627e5e764cc79aced3d451ab88bb04f

gdb/ChangeLog
2019-10-29  Tom Tromey  <tromey@adacore.com>

	* windows-nat.c (exception_count, event_count): Remove.
	(handle_exception, get_windows_debug_event)
	(do_initial_windows_stuff): Update.

Change-Id: I44f3d150deefc9046ddcdc7321a8989bc4f7a16a
---
M gdb/ChangeLog
M gdb/windows-nat.c
2 files changed, 6 insertions(+), 6 deletions(-)



diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c8e9228..bf55033 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-10-29  Tom Tromey  <tromey@adacore.com>
 
+	* windows-nat.c (exception_count, event_count): Remove.
+	(handle_exception, get_windows_debug_event)
+	(do_initial_windows_stuff): Update.
+
+2019-10-29  Tom Tromey  <tromey@adacore.com>
+
 	* windows-nat.c (windows_nat::handle_load_dll)
 	(windows_nat::handle_unload_dll): Rename.  No longer static.
 	* nat/windows-nat.h (handle_load_dll, handle_unload_dll):
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 8bad871..159b093 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -217,8 +217,6 @@
 
 
 /* Counts of things.  */
-static int exception_count = 0;
-static int event_count = 0;
 static int saw_create;
 static int open_process_used = 0;
 
@@ -1209,7 +1207,6 @@
       ourstatus->value.sig = GDB_SIGNAL_UNKNOWN;
       break;
     }
-  exception_count++;
   last_sig = ourstatus->value.sig;
   return result;
 }
@@ -1495,7 +1492,6 @@
   if (!(debug_event = wait_for_debug_event (&current_event, 1000)))
     goto out;
 
-  event_count++;
   continue_status = DBG_CONTINUE;
 
   event_code = current_event.dwDebugEventCode;
@@ -1827,8 +1823,6 @@
   struct inferior *inf;
 
   last_sig = GDB_SIGNAL_0;
-  event_count = 0;
-  exception_count = 0;
   open_process_used = 0;
   debug_registers_changed = 0;
   debug_registers_used = 0;

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I44f3d150deefc9046ddcdc7321a8989bc4f7a16a
Gerrit-Change-Number: 424
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange

       reply	other threads:[~2019-10-29 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 18:05 Tom Tromey (Code Review) [this message]
2019-11-19 22:41 ` Pedro Alves (Code Review)
2019-11-26 17:12 Tom Tromey (Code Review)
2019-11-29 19:56 ` Pedro Alves (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gerrit.1572371871000.I44f3d150deefc9046ddcdc7321a8989bc4f7a16a@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).