* [review] Display "main" on initial TUI startup
@ 2019-11-14 23:36 Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-14 23:36 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/644
......................................................................
Display "main" on initial TUI startup
I noticed that even when there's a symbol file, "tui enable" won't
show "main" by default. I think it should, and this patch fixes this.
gdb/ChangeLog
2019-11-14 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable): Call tui_display_main.
gdb/testsuite/ChangeLog
2019-11-14 Tom Tromey <tom@tromey.com>
* gdb.tui/list.exp: Check for source on initial listing.
Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
---
M gdb/ChangeLog
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.tui/list.exp
M gdb/tui/tui.c
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a2171c3..7454ecd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-11-14 Tom Tromey <tom@tromey.com>
+ * tui/tui.c (tui_enable): Call tui_display_main.
+
+2019-11-14 Tom Tromey <tom@tromey.com>
+
* tui/tui-disasm.c (tui_get_begin_asm_address): Use
get_current_source_symtab_and_line, and main_name.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3a4d229..b79729d 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-11-14 Tom Tromey <tom@tromey.com>
+
+ * gdb.tui/list.exp: Check for source on initial listing.
+
2019-11-14 Tom Tromey <tromey@adacore.com>
* gdb.base/gdbvars.exp (test_convenience_variables): Add
diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp
index 6efe193..08153c6 100644
--- a/gdb/testsuite/gdb.tui/list.exp
+++ b/gdb/testsuite/gdb.tui/list.exp
@@ -28,7 +28,7 @@
unsupported "TUI not supported"
}
-Term::check_contents "initial source listing" "No Source Available"
+Term::check_contents "initial source listing" "21 *return 0"
Term::command "layout asm"
Term::check_contents "asm window shows main" "$hex <main>"
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index ae81fc9..e076ce3 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -512,6 +512,8 @@
if (deprecated_safe_get_selected_frame ())
tui_show_frame_info (deprecated_safe_get_selected_frame ());
+ else
+ tui_display_main ();
/* Restore TUI keymap. */
tui_set_key_mode (tui_current_key_mode);
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
Gerrit-Change-Number: 644
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 4+ messages in thread
* [review v2] Display "main" on initial TUI startup
2019-11-14 23:36 [review] Display "main" on initial TUI startup Tom Tromey (Code Review)
@ 2019-12-12 2:41 ` Tom Tromey (Code Review)
2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 2:41 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/644
......................................................................
Display "main" on initial TUI startup
I noticed that even when there's a symbol file, "tui enable" won't
show "main" by default. I think it should, and this patch fixes this.
2019-12-11 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable): Call tui_display_main.
gdb/testsuite/ChangeLog
2019-12-11 Tom Tromey <tom@tromey.com>
* gdb.tui/list.exp: Check for source on initial listing.
Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
---
M gdb/ChangeLog
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.tui/list.exp
M gdb/tui/tui.c
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 58eb3bb..fa571fc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-11 Tom Tromey <tom@tromey.com>
+ * tui/tui.c (tui_enable): Call tui_display_main.
+
+2019-12-11 Tom Tromey <tom@tromey.com>
+
* tui/tui-disasm.c (tui_get_begin_asm_address): Use
get_current_source_symtab_and_line, and main_name.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index b31e8dd..cb575fe 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2019-12-11 Tom Tromey <tom@tromey.com>
+ * gdb.tui/list.exp: Check for source on initial listing.
+
+2019-12-11 Tom Tromey <tom@tromey.com>
+
* gdb.tui/resize.exp: Fix regexp.
* gdb.tui/regs.exp: Fix regexps.
* gdb.tui/main.exp: Fix regexp.
diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp
index 6efe193..08153c6 100644
--- a/gdb/testsuite/gdb.tui/list.exp
+++ b/gdb/testsuite/gdb.tui/list.exp
@@ -28,7 +28,7 @@
unsupported "TUI not supported"
}
-Term::check_contents "initial source listing" "No Source Available"
+Term::check_contents "initial source listing" "21 *return 0"
Term::command "layout asm"
Term::check_contents "asm window shows main" "$hex <main>"
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index a0d2e4c..dbc890a 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -513,6 +513,8 @@
if (deprecated_safe_get_selected_frame ())
tui_show_frame_info (deprecated_safe_get_selected_frame ());
+ else
+ tui_display_main ();
/* Restore TUI keymap. */
tui_set_key_mode (tui_current_key_mode);
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
Gerrit-Change-Number: 644
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Display "main" on initial TUI startup
2019-11-14 23:36 [review] Display "main" on initial TUI startup Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:20 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/644
......................................................................
Display "main" on initial TUI startup
I noticed that even when there's a symbol file, "tui enable" won't
show "main" by default. I think it should, and this patch fixes this.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable): Call tui_display_main.
gdb/testsuite/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* gdb.tui/list.exp: Check for source on initial listing.
Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
---
M gdb/ChangeLog
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.tui/list.exp
M gdb/tui/tui.c
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e471536..1034aa8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-20 Tom Tromey <tom@tromey.com>
+ * tui/tui.c (tui_enable): Call tui_display_main.
+
+2019-12-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-disasm.c (tui_get_begin_asm_address): Use
get_current_source_symtab_and_line, and main_name.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4f8d851..f25787c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-20 Tom Tromey <tom@tromey.com>
+
+ * gdb.tui/list.exp: Check for source on initial listing.
+
2019-12-11 Tom Tromey <tromey@adacore.com>
* gdb.xml/tdesc-arch.exp (set_arch): Add "trans_mode" parameter.
diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp
index 6efe193..08153c6 100644
--- a/gdb/testsuite/gdb.tui/list.exp
+++ b/gdb/testsuite/gdb.tui/list.exp
@@ -28,7 +28,7 @@
unsupported "TUI not supported"
}
-Term::check_contents "initial source listing" "No Source Available"
+Term::check_contents "initial source listing" "21 *return 0"
Term::command "layout asm"
Term::check_contents "asm window shows main" "$hex <main>"
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index a0d2e4c..dbc890a 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -513,6 +513,8 @@
if (deprecated_safe_get_selected_frame ())
tui_show_frame_info (deprecated_safe_get_selected_frame ());
+ else
+ tui_display_main ();
/* Restore TUI keymap. */
tui_set_key_mode (tui_current_key_mode);
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
Gerrit-Change-Number: 644
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Display "main" on initial TUI startup
2019-11-14 23:36 [review] Display "main" on initial TUI startup Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:20 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/644
......................................................................
Display "main" on initial TUI startup
I noticed that even when there's a symbol file, "tui enable" won't
show "main" by default. I think it should, and this patch fixes this.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable): Call tui_display_main.
gdb/testsuite/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* gdb.tui/list.exp: Check for source on initial listing.
Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
---
M gdb/ChangeLog
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.tui/list.exp
M gdb/tui/tui.c
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e471536..1034aa8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-20 Tom Tromey <tom@tromey.com>
+ * tui/tui.c (tui_enable): Call tui_display_main.
+
+2019-12-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-disasm.c (tui_get_begin_asm_address): Use
get_current_source_symtab_and_line, and main_name.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4f8d851..f25787c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-20 Tom Tromey <tom@tromey.com>
+
+ * gdb.tui/list.exp: Check for source on initial listing.
+
2019-12-11 Tom Tromey <tromey@adacore.com>
* gdb.xml/tdesc-arch.exp (set_arch): Add "trans_mode" parameter.
diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp
index 6efe193..08153c6 100644
--- a/gdb/testsuite/gdb.tui/list.exp
+++ b/gdb/testsuite/gdb.tui/list.exp
@@ -28,7 +28,7 @@
unsupported "TUI not supported"
}
-Term::check_contents "initial source listing" "No Source Available"
+Term::check_contents "initial source listing" "21 *return 0"
Term::command "layout asm"
Term::check_contents "asm window shows main" "$hex <main>"
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index a0d2e4c..dbc890a 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -513,6 +513,8 @@
if (deprecated_safe_get_selected_frame ())
tui_show_frame_info (deprecated_safe_get_selected_frame ());
+ else
+ tui_display_main ();
/* Restore TUI keymap. */
tui_set_key_mode (tui_current_key_mode);
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064
Gerrit-Change-Number: 644
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-20 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 23:36 [review] Display "main" on initial TUI startup Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).