* [review] [Obvious] Remove stale FIXME comment
@ 2019-11-27 20:27 Luis Machado (Code Review)
2019-12-02 14:24 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review)
0 siblings, 2 replies; 3+ messages in thread
From: Luis Machado (Code Review) @ 2019-11-27 20:27 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/732
......................................................................
[Obvious] Remove stale FIXME comment
While debugging something, i noticed this odd FIXME comment. It seems stale
and therefore here's a patch removing it.
gdb/ChangeLog:
2019-11-27 Luis Machado <luis.machado@linaro.org>
* infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
---
M gdb/infrun.c
1 file changed, 0 insertions(+), 1 deletion(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 3718674..6a346d6 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -432,7 +432,6 @@
Can not resume the parent process over vfork in the foreground while\n\
holding the child stopped. Try \"set detach-on-fork\" or \
\"set schedule-multiple\".\n"));
- /* FIXME output string > 80 columns. */
return 1;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
Gerrit-Change-Number: 732
Gerrit-PatchSet: 1
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pushed] Remove stale FIXME comment
2019-11-27 20:27 [review] [Obvious] Remove stale FIXME comment Luis Machado (Code Review)
2019-12-02 14:24 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review)
1 sibling, 0 replies; 3+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-02 14:24 UTC (permalink / raw)
To: Luis Machado, gdb-patches
The original change was created by Luis Machado.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/732
......................................................................
Remove stale FIXME comment
While debugging something, i noticed this odd FIXME comment. It seems stale
and therefore here's a patch removing it.
gdb/ChangeLog:
2019-12-02 Luis Machado <luis.machado@linaro.org>
* infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
---
M gdb/ChangeLog
M gdb/infrun.c
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1465c75..b8cb710 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-02 Luis Machado <luis.machado@linaro.org>
+
+ * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
+
2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
* dwarf2read.c (read_tag_string_type): Read the fields required to
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 3718674..6a346d6 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -432,7 +432,6 @@
Can not resume the parent process over vfork in the foreground while\n\
holding the child stopped. Try \"set detach-on-fork\" or \
\"set schedule-multiple\".\n"));
- /* FIXME output string > 80 columns. */
return 1;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
Gerrit-Change-Number: 732
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pushed] Remove stale FIXME comment
2019-11-27 20:27 [review] [Obvious] Remove stale FIXME comment Luis Machado (Code Review)
@ 2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review)
2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review)
1 sibling, 0 replies; 3+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-02 14:24 UTC (permalink / raw)
To: Luis Machado, gdb-patches
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/732
......................................................................
Remove stale FIXME comment
While debugging something, i noticed this odd FIXME comment. It seems stale
and therefore here's a patch removing it.
gdb/ChangeLog:
2019-12-02 Luis Machado <luis.machado@linaro.org>
* infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
---
M gdb/ChangeLog
M gdb/infrun.c
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1465c75..b8cb710 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-02 Luis Machado <luis.machado@linaro.org>
+
+ * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
+
2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
* dwarf2read.c (read_tag_string_type): Read the fields required to
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 3718674..6a346d6 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -432,7 +432,6 @@
Can not resume the parent process over vfork in the foreground while\n\
holding the child stopped. Try \"set detach-on-fork\" or \
\"set schedule-multiple\".\n"));
- /* FIXME output string > 80 columns. */
return 1;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
Gerrit-Change-Number: 732
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-02 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 20:27 [review] [Obvious] Remove stale FIXME comment Luis Machado (Code Review)
2019-12-02 14:24 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).