public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [patch] gdbserver: print inferior argv --debug
@ 2010-04-20  7:21 Doug Evans
  2010-04-20  7:53 ` Pierre Muller
       [not found] ` <-6536644988877721859@unknownmsgid>
  0 siblings, 2 replies; 4+ messages in thread
From: Doug Evans @ 2010-04-20  7:21 UTC (permalink / raw)
  To: gdb-patches

Hi.

I found this helpful debugging gdbserver --wrapper.

I will check it in in a few days if there are no objections.

2010-04-20  Doug Evans  <dje@google.com>

	* server.c (start_inferior): Print inferior argv if --debug.

Index: server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.116
diff -u -p -r1.116 server.c
--- server.c	16 Apr 2010 07:49:36 -0000	1.116
+++ server.c	20 Apr 2010 07:14:54 -0000
@@ -241,6 +241,14 @@ start_inferior (char **argv)
       new_argv[count] = NULL;
     }
 
+  if (debug_threads)
+    {
+      int i;
+      for (i = 0; new_argv[i]; ++i)
+	fprintf (stderr, "new_argv[%d] = %s\n", i, new_argv[i]);
+      fflush (stderr);
+    }
+
 #ifdef SIGTTOU
   signal (SIGTTOU, SIG_DFL);
   signal (SIGTTIN, SIG_DFL);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [patch] gdbserver: print inferior argv --debug
  2010-04-20  7:21 [patch] gdbserver: print inferior argv --debug Doug Evans
@ 2010-04-20  7:53 ` Pierre Muller
       [not found] ` <-6536644988877721859@unknownmsgid>
  1 sibling, 0 replies; 4+ messages in thread
From: Pierre Muller @ 2010-04-20  7:53 UTC (permalink / raw)
  To: 'Doug Evans', gdb-patches

Not an objection, rather a suggestion:
what about wrapping these args into double quotes to
see embedded spaces like this:
> +	fprintf (stderr, "new_argv[%d] = \"%s\"\n", i, new_argv[i]);

Pierre Muller

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Doug Evans
> Envoyé : Tuesday, April 20, 2010 9:21 AM
> À : gdb-patches@sourceware.org
> Objet : [patch] gdbserver: print inferior argv --debug
> 
> Hi.
> 
> I found this helpful debugging gdbserver --wrapper.
> 
> I will check it in in a few days if there are no objections.
> 
> 2010-04-20  Doug Evans  <dje@google.com>
> 
> 	* server.c (start_inferior): Print inferior argv if --debug.
> 
> Index: server.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
> retrieving revision 1.116
> diff -u -p -r1.116 server.c
> --- server.c	16 Apr 2010 07:49:36 -0000	1.116
> +++ server.c	20 Apr 2010 07:14:54 -0000
> @@ -241,6 +241,14 @@ start_inferior (char **argv)
>        new_argv[count] = NULL;
>      }
> 
> +  if (debug_threads)
> +    {
> +      int i;
> +      for (i = 0; new_argv[i]; ++i)
> +	fprintf (stderr, "new_argv[%d] = %s\n", i, new_argv[i]);
> +      fflush (stderr);
> +    }
> +
>  #ifdef SIGTTOU
>    signal (SIGTTOU, SIG_DFL);
>    signal (SIGTTIN, SIG_DFL);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] gdbserver: print inferior argv --debug
       [not found] ` <-6536644988877721859@unknownmsgid>
@ 2010-04-20  7:55   ` Doug Evans
  2010-04-24  0:59   ` Doug Evans
  1 sibling, 0 replies; 4+ messages in thread
From: Doug Evans @ 2010-04-20  7:55 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches

"works for me"

On Tue, Apr 20, 2010 at 12:53 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> Not an objection, rather a suggestion:
> what about wrapping these args into double quotes to
> see embedded spaces like this:
>> +     fprintf (stderr, "new_argv[%d] = \"%s\"\n", i, new_argv[i]);
>
> Pierre Muller
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoyé : Tuesday, April 20, 2010 9:21 AM
>> À : gdb-patches@sourceware.org
>> Objet : [patch] gdbserver: print inferior argv --debug
>>
>> Hi.
>>
>> I found this helpful debugging gdbserver --wrapper.
>>
>> I will check it in in a few days if there are no objections.
>>
>> 2010-04-20  Doug Evans  <dje@google.com>
>>
>>       * server.c (start_inferior): Print inferior argv if --debug.
>>
>> Index: server.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>> retrieving revision 1.116
>> diff -u -p -r1.116 server.c
>> --- server.c  16 Apr 2010 07:49:36 -0000      1.116
>> +++ server.c  20 Apr 2010 07:14:54 -0000
>> @@ -241,6 +241,14 @@ start_inferior (char **argv)
>>        new_argv[count] = NULL;
>>      }
>>
>> +  if (debug_threads)
>> +    {
>> +      int i;
>> +      for (i = 0; new_argv[i]; ++i)
>> +     fprintf (stderr, "new_argv[%d] = %s\n", i, new_argv[i]);
>> +      fflush (stderr);
>> +    }
>> +
>>  #ifdef SIGTTOU
>>    signal (SIGTTOU, SIG_DFL);
>>    signal (SIGTTIN, SIG_DFL);
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] gdbserver: print inferior argv --debug
       [not found] ` <-6536644988877721859@unknownmsgid>
  2010-04-20  7:55   ` Doug Evans
@ 2010-04-24  0:59   ` Doug Evans
  1 sibling, 0 replies; 4+ messages in thread
From: Doug Evans @ 2010-04-24  0:59 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches

Thanks.  I checked this in with the added double-quotes.

On Tue, Apr 20, 2010 at 12:53 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> Not an objection, rather a suggestion:
> what about wrapping these args into double quotes to
> see embedded spaces like this:
>> +     fprintf (stderr, "new_argv[%d] = \"%s\"\n", i, new_argv[i]);
>
> Pierre Muller
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoyé : Tuesday, April 20, 2010 9:21 AM
>> À : gdb-patches@sourceware.org
>> Objet : [patch] gdbserver: print inferior argv --debug
>>
>> Hi.
>>
>> I found this helpful debugging gdbserver --wrapper.
>>
>> I will check it in in a few days if there are no objections.
>>
>> 2010-04-20  Doug Evans  <dje@google.com>
>>
>>       * server.c (start_inferior): Print inferior argv if --debug.
>>
>> Index: server.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>> retrieving revision 1.116
>> diff -u -p -r1.116 server.c
>> --- server.c  16 Apr 2010 07:49:36 -0000      1.116
>> +++ server.c  20 Apr 2010 07:14:54 -0000
>> @@ -241,6 +241,14 @@ start_inferior (char **argv)
>>        new_argv[count] = NULL;
>>      }
>>
>> +  if (debug_threads)
>> +    {
>> +      int i;
>> +      for (i = 0; new_argv[i]; ++i)
>> +     fprintf (stderr, "new_argv[%d] = %s\n", i, new_argv[i]);
>> +      fflush (stderr);
>> +    }
>> +
>>  #ifdef SIGTTOU
>>    signal (SIGTTOU, SIG_DFL);
>>    signal (SIGTTIN, SIG_DFL);
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-04-24  0:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-20  7:21 [patch] gdbserver: print inferior argv --debug Doug Evans
2010-04-20  7:53 ` Pierre Muller
     [not found] ` <-6536644988877721859@unknownmsgid>
2010-04-20  7:55   ` Doug Evans
2010-04-24  0:59   ` Doug Evans

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).