From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30798 invoked by alias); 2 Apr 2010 15:28:03 -0000 Received: (qmail 30775 invoked by uid 22791); 2 Apr 2010 15:28:02 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Apr 2010 15:27:57 +0000 Received: by vws4 with SMTP id 4so1239561vws.0 for ; Fri, 02 Apr 2010 08:27:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.90.201 with HTTP; Fri, 2 Apr 2010 08:27:55 -0700 (PDT) In-Reply-To: <201004021441.o32EfT7s024414@glazunov.sibelius.xs4all.nl> References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com> <20100304180643.GB10869@intel.com> <20100306222037.GD21133@intel.com> <20100312164930.GB6144@intel.com> <20100329011124.GA27275@intel.com> <20100402143107.GA24450@intel.com> <201004021441.o32EfT7s024414@glazunov.sibelius.xs4all.nl> Date: Fri, 02 Apr 2010 15:28:00 -0000 Received: by 10.220.108.27 with SMTP id d27mr1174377vcp.232.1270222075765; Fri, 02 Apr 2010 08:27:55 -0700 (PDT) Message-ID: Subject: Re: PATCH: 3/6 [3rd try]: Add AVX support (i386 changes) From: "H.J. Lu" To: Mark Kettenis Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00048.txt.bz2 On Fri, Apr 2, 2010 at 7:41 AM, Mark Kettenis wro= te: >> Date: Fri, 2 Apr 2010 07:31:07 -0700 >> From: "H.J. Lu" >> >> On Sun, Mar 28, 2010 at 06:11:24PM -0700, H.J. Lu wrote: >> > Hi, >> > >> > Here are i386 changes to support AVX. OK to install? >> > >> >> Here is the updated i386 changes to support AVX. OK to install? > > Sorry, but I'm still unhappy with the way you modify the > i386_linux_regset_sections[] array at run time. =A0I think the best > thing to do is to have gcore *always* create a NT_X86_XSTATE note of Generate NT_X86_XSTATE note without kernel/processor NT_X86_XSTATE note support may require changes to existing FXSAVE code path. I will investigate it. BTW, I have a follow up patch to implement 32bit core registers without SSE registers to properly support older processors, like Pentium and Pentium Pro. Should "gcore" generate NT_PRXFPREG note? > the maximum size supported by GDB. =A0That way you can remove a lot of > code (including the duplication of code in i387_collect_xsave). > XSAVE is different from FXSAVE in some subtle ways, although XSAVE memory layout is an extension to FXSAVE memory layout. XSAVE has used or initialized states for SSE and AVX registers. Most of the codes in i387_collect_xsave deal with used/initialized states. Please identify the duplication of code in i387_collect_xsave. I will take a look. Thanks. --=20 H.J.