From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6272 invoked by alias); 7 May 2012 19:54:13 -0000 Received: (qmail 6264 invoked by uid 22791); 7 May 2012 19:54:12 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 May 2012 19:53:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q47JrsVx006310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 May 2012 15:53:54 -0400 Received: from psique ([10.3.112.12]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q47Jro7G002879; Mon, 7 May 2012 15:53:52 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Implement support for SystemTap probes References: <20120507193538.GA6283@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Mon, 07 May 2012 19:54:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00193.txt.bz2 On Monday, May 07 2012, Jan Kratochvil wrote: > I have found I have asked three times on this list (IIRC even elsewhere) to > fix this debuginfo probes bug and in the end it got checked in with this bug > anyway. Could you fix it, please? You are right, I am sorry. I was sure I had fixed the bug, but now I see that I actually hacked the wrong function. Does this patch work for you? Thanks, -- Sergio 2012-05-07 Sergio Durigan Junior * probe.c (collect_probes): Filtering debuginfo object files. diff --git a/gdb/probe.c b/gdb/probe.c index ee94f9c..832e57c 100644 --- a/gdb/probe.c +++ b/gdb/probe.c @@ -303,6 +303,9 @@ collect_probes (char *objname, char *provider, char *probe_name, if (! objfile->sf || ! objfile->sf->sym_probe_fns) continue; + if (objfile->separate_debug_objfile_backlink != NULL) + continue; + if (objname) { if (regexec (&obj_pat, objfile->name, 0, NULL, 0) != 0)