From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63085 invoked by alias); 26 Oct 2015 05:32:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63076 invoked by uid 89); 26 Oct 2015 05:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 26 Oct 2015 05:32:10 +0000 Received: by pacfv9 with SMTP id fv9so185113184pac.3 for ; Sun, 25 Oct 2015 22:32:09 -0700 (PDT) X-Received: by 10.66.168.228 with SMTP id zz4mr19571173pab.133.1445837528950; Sun, 25 Oct 2015 22:32:08 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id i9sm31388043pbq.84.2015.10.25.22.32.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Oct 2015 22:32:08 -0700 (PDT) From: Doug Evans To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH c++ 10/12] symtab.c: Add cast References: <1445831204-16588-1-git-send-email-simon.marchi@polymtl.ca> <1445831204-16588-10-git-send-email-simon.marchi@polymtl.ca> Date: Mon, 26 Oct 2015 12:55:00 -0000 In-Reply-To: <1445831204-16588-10-git-send-email-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 25 Oct 2015 23:46:42 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00548.txt.bz2 Simon Marchi writes: > gdb/ChangeLog: > > * symtab.c (default_make_symbol_completion_list_break_on_1): Add > cast. > --- > gdb/symtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/symtab.c b/gdb/symtab.c > index b0a16b6..16190c4 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -5422,7 +5422,7 @@ default_make_symbol_completion_list_break_on_1 (const char *text, > /* These languages may have parameters entered by user but they are never > present in the partial symbol tables. */ > > - const char *cs = memchr (sym_text, '(', sym_text_len); > + const char *cs = (const char *) memchr (sym_text, '(', sym_text_len); > > if (cs) > sym_text_len = cs - sym_text; LGTM