From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29658 invoked by alias); 5 Dec 2014 22:58:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29646 invoked by uid 89); 5 Dec 2014 22:58:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 05 Dec 2014 22:58:56 +0000 Received: by mail-pa0-f54.google.com with SMTP id fb1so1560671pad.13 for ; Fri, 05 Dec 2014 14:58:54 -0800 (PST) X-Received: by 10.68.69.78 with SMTP id c14mr39175762pbu.68.1417820334578; Fri, 05 Dec 2014 14:58:54 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id v4sm29857827pbs.10.2014.12.05.14.58.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 14:58:53 -0800 (PST) From: Doug Evans To: Gary Benson Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH 2/3 v2] Interleave completion list building with symbol table expansion References: <1417094168-25868-1-git-send-email-gbenson@redhat.com> <1417094168-25868-3-git-send-email-gbenson@redhat.com> Date: Fri, 05 Dec 2014 22:58:00 -0000 In-Reply-To: <1417094168-25868-3-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Thu, 27 Nov 2014 13:16:07 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00156.txt.bz2 Gary Benson writes: > This commit makes default_make_symbol_completion_list_break_on build > the list of completions as it expands the necessary symbol tables, > rather than expanding all necessary symbol tables first and then > building the completion lists second. This allows for the early > termination of symbol table expansion if required. > > gdb/ChangeLog: > > * symtab.c (struct add_name_data) : New field. > Updated comments. > (add_symtab_completions): New function. > (symtab_expansion_callback): Likewise. > (default_make_symbol_completion_list_break_on): Set datum.code. > Move minimal symbol scan before calling expand_symtabs_matching. > Scan known primary symtabs for externs and statics before calling > expand_symtabs_matching. Pass symtab_expansion_callback as > expansion_notify argument to expand_symtabs_matching. Do not scan > primary symtabs for externs and statics after calling > expand_symtabs_matching. LGTM