From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete]
Date: Fri, 20 Aug 2010 21:54:00 -0000 [thread overview]
Message-ID: <m339u9ympv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C6EE3B4.1090906@redhat.com> (sami wagiaalla's message of "Fri, 20 Aug 2010 16:21:08 -0400")
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> suppressed one too many regressions. Specifically (if you look at
Sami> 3b26cb4b133^) the regression on line 10185 when the tag is
Sami> DW_TAG_template_value_param and DW_AT_location != NULL.
I don't think this patch is correct.
IIUC it will go ahead and add the template parameters to whatever scope
is being read. That isn't right, and in fact that is what suppress_add
was intended to prevent.
I see that I missed some case in the suppress_add patch.
But that is an oversight -- I think the code in dwarf2read.c as it is
now looks ok.
Tom
next prev parent reply other threads:[~2010-08-20 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 15:28 [patch] Defer symbol addition until construction is complete sami wagiaalla
2010-07-29 20:58 ` Tom Tromey
2010-08-09 18:38 ` sami wagiaalla
2010-08-09 19:55 ` Tom Tromey
2010-08-10 7:44 ` Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] Jan Kratochvil
2010-08-10 14:34 ` sami wagiaalla
2010-08-20 20:21 ` sami wagiaalla
2010-08-20 21:54 ` Tom Tromey [this message]
2010-08-31 15:18 ` sami wagiaalla
2010-08-31 18:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339u9ympv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).