From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 718 invoked by alias); 20 Aug 2010 21:54:17 -0000 Received: (qmail 706 invoked by uid 22791); 20 Aug 2010 21:54:16 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Aug 2010 21:54:08 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7KLs7CR021897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Aug 2010 17:54:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7KLs6Hh022947; Fri, 20 Aug 2010 17:54:06 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7KLs6AR031613; Fri, 20 Aug 2010 17:54:06 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9C59537897B; Fri, 20 Aug 2010 15:54:05 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] References: <4C446F09.50107@redhat.com> <4C604B22.4060904@redhat.com> <20100810074402.GA19162@host1.dyn.jankratochvil.net> <4C616374.7080700@redhat.com> <4C6EE3B4.1090906@redhat.com> Date: Fri, 20 Aug 2010 21:54:00 -0000 In-Reply-To: <4C6EE3B4.1090906@redhat.com> (sami wagiaalla's message of "Fri, 20 Aug 2010 16:21:08 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00374.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> suppressed one too many regressions. Specifically (if you look at Sami> 3b26cb4b133^) the regression on line 10185 when the tag is Sami> DW_TAG_template_value_param and DW_AT_location != NULL. I don't think this patch is correct. IIUC it will go ahead and add the template parameters to whatever scope is being read. That isn't right, and in fact that is what suppress_add was intended to prevent. I see that I missed some case in the suppress_add patch. But that is an oversight -- I think the code in dwarf2read.c as it is now looks ok. Tom