Re: [RFA]corelow.c: Add tid to add_to_thread_list

[Tom Tromey <tromey@redhat.com>]

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> I make a patch for kernel (http://lkml.org/lkml/2010/8/3/75) but they
>> think it should be fixed in user space.
>> So I add the tid to add_to_thread_list.

I don't know about this area of gdb, so I can't really comment on the
semantics of the change, but I do have a comment about how the change is
written:

>> -  ptid = ptid_build (pid, lwpid, 0);
>> +  tid = 0;
>> +get_ptid:
>> +  ptid = ptid_build (pid, lwpid, tid);
>> +  if (find_thread_ptid (ptid))
>> +    {
>> +      tid ++;
>> +      goto get_ptid;
>> +    }

I think this would be more readably written without 'goto', as a loop.

Tom