From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 844 invoked by alias); 16 Nov 2014 22:28:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 833 invoked by uid 89); 16 Nov 2014 22:28:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f174.google.com Received: from mail-pd0-f174.google.com (HELO mail-pd0-f174.google.com) (209.85.192.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 16 Nov 2014 22:28:20 +0000 Received: by mail-pd0-f174.google.com with SMTP id w10so1172267pde.33 for ; Sun, 16 Nov 2014 14:28:18 -0800 (PST) X-Received: by 10.70.33.73 with SMTP id p9mr25312833pdi.103.1416176898327; Sun, 16 Nov 2014 14:28:18 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id ug8sm33380848pab.40.2014.11.16.14.28.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 14:28:17 -0800 (PST) From: Doug Evans To: "Maciej W. Rozycki" Cc: Joel Brobecker , , Rich Fuhler , Richard Sandiford Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests References: <20120611182043.GA7597@adacore.com> Date: Sun, 16 Nov 2014 22:28:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Mon, 6 Oct 2014 01:42:10 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00385.txt.bz2 "Maciej W. Rozycki" writes: > Joel, > > Here's the second change, to cover issues triggered by the MIPS ISA bit > handling change, usually in tests that make artificial DWARF-2 records. > > [...] > 2014-10-06 Maciej W. Rozycki > > gdb/testsuite/ > * gdb.cp/expand-psymtabs-cxx.exp: Accept any address of > `method(long)', not just 0x0. > * gdb.cp/nsalias.exp: Align code labels to 4. > * gdb.dwarf2/dw2-canonicalize-type.S (main): Expand to 4-bytes. > * gdb.dwarf2/dw2-empty-pc-range.S (main): Likewise. > * gdb.dwarf2/pr11465.S (_ZN1N1cE): Likewise. > * gdb.dwarf2/dw2-case-insensitive.c (START_INSNS): New macro. > (cu_text_start, FUNC_lang_start): Use `START_INSNS'. > * gdb.dwarf2/dw2-stack-boundary.exp: Accept noise in complaints. > [...] > Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c 2014-10-02 07:56:23.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c 2014-10-02 07:58:10.978958268 +0100 > @@ -15,13 +15,22 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > +/* Target-specific way of forcing an instruction label. */ > +#ifdef __mips__ > +#define START_INSNS asm (".insn"); > +#else > +#define START_INSNS > +#endif > + > /* Use DW_LANG_Fortran90 for case insensitive DWARF. */ > asm (".globl cu_text_start"); > asm ("cu_text_start:"); > +START_INSNS > > asm (".globl FUNC_lang_start"); > asm (".p2align 4"); > asm ("FUNC_lang_start:"); > +START_INSNS > > void > FUNC_lang (void) Hi. Just a note to say this will probably not work with clang, but this test is already clang unfriendly. We can leave fixing that for another day. I have no other comments on the part of the patch set, so ok by me (with the .4byte change). [Still working on part 1.]