From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12851 invoked by alias); 7 Feb 2011 15:00:31 -0000 Received: (qmail 12841 invoked by uid 22791); 7 Feb 2011 15:00:29 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,FSL_RU_URL,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Feb 2011 15:00:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p17F0NYB004953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Feb 2011 10:00:23 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p17F0M7W015343; Mon, 7 Feb 2011 10:00:23 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p17F0LjN016087; Mon, 7 Feb 2011 10:00:21 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 49D76378334; Mon, 7 Feb 2011 08:00:21 -0700 (MST) From: Tom Tromey To: Vladimir Simonov Cc: gdb-patches@sourceware.org Subject: Re: gdb: Incorrect stack unwinding if compressed debug info is used References: <1296238472.3009.ezmlm@sourceware.org> <4D46D872.6080407@sw.ru> <4D4C383A.3000203@sw.ru> <4D4C4576.2020709@sw.ru> <4D4D52F2.7080802@sw.ru> Date: Mon, 07 Feb 2011 15:00:00 -0000 In-Reply-To: <4D4D52F2.7080802@sw.ru> (Vladimir Simonov's message of "Sat, 05 Feb 2011 16:38:58 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00149.txt.bz2 >>>>> "Vladimir" == Vladimir Simonov writes: Vladimir> Please see attached patch. Hope it explains what I meant under Vladimir> "change dwarf2_read_section". Vladimir> If such changes are not acceptable by some reason(performance?, Vladimir> readability?, something else) then I'm OK with current naming. I'm sorry I didn't reply to that part of your message the first time. I think the current code is a bit clearer, because seeing "dwarf2_read_section" in a conditional seems strange, but seeing "dwarf2_section_size" does not. However, it is a minor point. I would probably approve either patch :-) Vladimir> I definitely don't insist on such changes, I just interested Vladimir> in understanding gdb "coding policy". If it is difficult Vladimir> to explain please ignore this mail. For something like this it is just a matter of personal taste, unless some argument emerges to prefer one approach over the other. I think I try to defer to other maintainers or to the original patch submitter on matters of naming, but it is hard to say if that is what I actually do ;-) Tom