public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: Python coding style
Date: Fri, 08 Oct 2010 21:35:00 -0000	[thread overview]
Message-ID: <m34ocws70g.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTimW2EkxxpDts1_P0YE++s9T=zeKDpiJSWo_SRHO@mail.gmail.com>	(Doug Evans's message of "Fri, 8 Oct 2010 14:19:48 -0700")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I think Google's guide specifies more, and specifies the reasons more.
Doug> We *could* reference both, and a blanket statement that X wins when
Doug> there's a conflict.
Doug> And then provide a supplement for gdb-specifics.
Doug> Easier than writing our own from scratch.

Works for me.

Tom> * We shouldn't use the #!/usr/bin/env thing

Doug> For my own education, why not?
Doug> [So I can document it in the style guide.]

I think that is there so that a given module can be run standalone.
That won't work with a typical gdb-specific module, since they can't
typically even be imported when using the plain python executable.

Doug> We should provide an emacs py mode that specifies our style.

We could check a .dir-locals.el file into the tree.  I'm using this
right now:

((tcl-mode . ((tcl-indent-level . 4)
	      (tcl-continued-indent-level . 4)))
 (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s"))))

Tom

      reply	other threads:[~2010-10-08 21:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:21 Python coding style [was Re: [RFA] New python module gdb.types] Doug Evans
2010-10-06 21:37 ` Phil Muldoon
2010-10-06 22:23   ` Joel Brobecker
2010-10-07  8:01     ` Phil Muldoon
2010-10-08 15:17       ` Joel Brobecker
2010-10-06 22:25 ` Python coding style Tom Tromey
2010-10-08 21:20   ` Doug Evans
2010-10-08 21:35     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34ocws70g.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).