From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 3/3] Fortran modules namespaces [rediff]
Date: Tue, 01 Jun 2010 22:01:00 -0000 [thread overview]
Message-ID: <m34ohm5s5l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100508055452.GA27443@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 8 May 2010 07:54:52 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Small update due to the checked-in `[patch 1/3] Make obconcat use stdarg'.
Thanks. I'm sorry about the long delay in reviewing this.
Jan> This case sensitivy problem is a bug of all of gdb, gfortran, PGF
Jan> and iFort, filed as GDB PR fortran/11560 and GCC PR debug/43950.
Yeah, and Pascal.
Jan> There has to be made a decision how to make fully-qualified reference of
Jan> symbols in modules. Fortran language itself must always import any such
Jan> symbol into the local namespace. C++ uses just "::" for such case.
Jan> iDB (Intel Debugger) uses character `
[...]
Jan> As GDB prints just "void" (or "VOID") on "$any$garbage" the
Jan> character $ is not usable and I have chosen '. If there are no
Jan> concerns about some compatibility with iDB I would vote for "::".
I think that if there is no choice arising from the language (I don't
know Fortran) then it is up to you.
Jan> --- a/gdb/cp-namespace.c
Jan> +++ b/gdb/cp-namespace.c
Jan> @@ -32,6 +32,7 @@
Jan> #include "command.h"
Jan> #include "frame.h"
Jan> #include "buildsym.h"
Jan> +#include "language.h"
Jan> static struct symbol *lookup_namespace_scope (const char *name,
Jan> const struct block *block,
Jan> @@ -260,6 +261,15 @@ cp_lookup_symbol_in_namespace (const char *namespace,
Jan> {
Jan> return lookup_symbol_file (name, block, domain, 0);
Jan> }
Jan> + else if (current_language->la_language == language_fortran)
I don't think we should introduce uses of current_language into this code.
It should probably just be an argument.
Tom
next prev parent reply other threads:[~2010-06-01 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 18:24 [patch 3/3] Fortran modules namespaces Jan Kratochvil
2010-05-08 5:55 ` [patch 3/3] Fortran modules namespaces [rediff] Jan Kratochvil
2010-06-01 22:01 ` Tom Tromey [this message]
2010-06-02 21:16 ` Jan Kratochvil
2010-06-02 22:03 ` Tom Tromey
2010-06-02 22:44 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34ohm5s5l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).