From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14968 invoked by alias); 1 Jun 2010 22:01:39 -0000 Received: (qmail 14683 invoked by uid 22791); 1 Jun 2010 22:01:38 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 22:01:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o51M1SNH000556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Jun 2010 18:01:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o51M1SK2017833; Tue, 1 Jun 2010 18:01:28 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o51M1RYH000321; Tue, 1 Jun 2010 18:01:28 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 393563782DC; Tue, 1 Jun 2010 16:01:27 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/3] Fortran modules namespaces [rediff] References: <20100430182409.GC19190@host0.dyn.jankratochvil.net> <20100508055452.GA27443@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 01 Jun 2010 22:01:00 -0000 In-Reply-To: <20100508055452.GA27443@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 8 May 2010 07:54:52 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00031.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Small update due to the checked-in `[patch 1/3] Make obconcat use stdarg'. Thanks. I'm sorry about the long delay in reviewing this. Jan> This case sensitivy problem is a bug of all of gdb, gfortran, PGF Jan> and iFort, filed as GDB PR fortran/11560 and GCC PR debug/43950. Yeah, and Pascal. Jan> There has to be made a decision how to make fully-qualified reference of Jan> symbols in modules. Fortran language itself must always import any such Jan> symbol into the local namespace. C++ uses just "::" for such case. Jan> iDB (Intel Debugger) uses character ` [...] Jan> As GDB prints just "void" (or "VOID") on "$any$garbage" the Jan> character $ is not usable and I have chosen '. If there are no Jan> concerns about some compatibility with iDB I would vote for "::". I think that if there is no choice arising from the language (I don't know Fortran) then it is up to you. Jan> --- a/gdb/cp-namespace.c Jan> +++ b/gdb/cp-namespace.c Jan> @@ -32,6 +32,7 @@ Jan> #include "command.h" Jan> #include "frame.h" Jan> #include "buildsym.h" Jan> +#include "language.h" Jan> static struct symbol *lookup_namespace_scope (const char *name, Jan> const struct block *block, Jan> @@ -260,6 +261,15 @@ cp_lookup_symbol_in_namespace (const char *namespace, Jan> { Jan> return lookup_symbol_file (name, block, domain, 0); Jan> } Jan> + else if (current_language->la_language == language_fortran) I don't think we should introduce uses of current_language into this code. It should probably just be an argument. Tom