From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31245 invoked by alias); 25 Feb 2016 17:16:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31166 invoked by uid 89); 25 Feb 2016 17:16:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=ditto, Ditto, lift X-HELO: e06smtp15.uk.ibm.com Received: from e06smtp15.uk.ibm.com (HELO e06smtp15.uk.ibm.com) (195.75.94.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 25 Feb 2016 17:16:15 +0000 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Feb 2016 17:16:11 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 25 Feb 2016 17:16:08 -0000 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7E5C417D805D for ; Thu, 25 Feb 2016 17:16:30 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1PHG8ZT6947220 for ; Thu, 25 Feb 2016 17:16:08 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1PGG9Qw008210 for ; Thu, 25 Feb 2016 09:16:10 -0700 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1PGG9Dr008196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Feb 2016 09:16:09 -0700 From: Andreas Arnez To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdbserver/s390: Enable high GPRs, VX, TDB with 31-bit gdbserver. References: <1455307062-8075-1-git-send-email-koriakin@0x04.net> Date: Thu, 25 Feb 2016 17:16:00 -0000 In-Reply-To: <1455307062-8075-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Fri, 12 Feb 2016 20:57:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16022517-0021-0000-0000-0000204D17C6 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00809.txt.bz2 On Fri, Feb 12 2016, Marcin Ko=C5=9Bcielnicki wrote: > Currently, 31-bit gdbserver doesn't support collecting/supplying high > GPRs, VX registers, and TDB data. This is not much of a problem now, > since machines that have them usually have a 64-bit gdbserver that can > be used to debug 31-bit targets just fine. However, with fast > tracepoints, it's not possible to use a 64-bit gdbserver with a 31-bit > IPA (and thus a 31-bit target), so 31-bit gdbserver has to be used > for 31-bit targets. Hm, this is an unfortunate restriction. It might be a good idea to lift that someday... Anyway -- > Thus, this patch is needed to allow collecting > high GPRs and VX registers on 31-bit targets via fast tracepoints. > > gdb/gdbserver/ChangeLog: > > * linux-s390-low.c (s390_num_regs_3264): Define on 31-bit too. > (s390_regmap_3264) [!__s390x__]: New global. > (s390_collect_ptrace_register): Skip map entries containing -1. > (s390_supply_ptrace_register): Ditto. > (s390_fill_gprs_high): New function. > (s390_store_gprs_high): New function. > (s390_regsets): Add NT_S390_HIGH_GPRS. > (s390_get_hwcap): Enable on 31-bit. > (have_hwcap_s390_high_gprs): Enable on 31-bit. > (s390_arch_setup): Enable detection of high GPRs, TDB, VX on 31-bit. > Detect NT_S390_HIGH_GPRS. > (s390_usrregs_info_3264): Enable on 31-bit. > (s390_regs_info): Enable regs_info_3264 on 31-bit. > (initialize_low_arch): Initialize s390_regsets_info_3264 on 31-bit. This is OK. Thanks for your contribution! --=20 Andreas Arnez