From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Regression setting breakpoint
Date: Thu, 16 Jan 2014 05:22:00 -0000 [thread overview]
Message-ID: <m361pkbiwk.fsf@redhat.com> (raw)
In-Reply-To: <52A8CD31.5090809@eagerm.com> (Michael Eager's message of "Wed, 11 Dec 2013 12:38:09 -0800")
On Wednesday, December 11 2013, Michael Eager wrote:
> From 6e6a7110f950e3d90978637b21fcb913934be9b1 Mon Sep 17 00:00:00 2001
> From: Michael Eager <eager@eagercon.com>
> Date: Tue, 10 Dec 2013 11:50:27 -0800
> Subject: [PATCH] Fix regression symbol name different from linkage name.
>
> gdb:
> * dwarf2read.c (die_needs_namespace): Do nothing for C language.
>
> testsuite:
> * gdb.base/break-linker-symname.c: New.
> * gdb.base/break-linker-symname.exp: New.
Not really a code review, but the ChangeLog entries should be of the
form:
2014-01-16 Your Name <you@email.com>
* file.c (function): What changed.
Also...
> diff --git a/gdb/testsuite/gdb.base/break-linker-symname.exp b/gdb/testsuite/gdb.base/break-linker-symname.exp
> new file mode 100644
> index 0000000..2a86f37
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/break-linker-symname.exp
> @@ -0,0 +1,25 @@
> +# Copyright 2013 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +# Test that 'set breakpoint always-inserted 1' is not a brick
> +# Also verifies that breakpoint enabling/disabling works properly
> +# with duplicated breakpoints.
> +
> +if { [prepare_for_testing break-linker-symname.exp break-linker-symname break-linker-symname.c] } {
> + return -1
> +}
You can rewrite this part as:
-----
standard_testfile
if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
return -1
}
-----
Thanks,
--
Sergio
next prev parent reply other threads:[~2014-01-16 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 20:38 Michael Eager
2014-01-16 5:22 ` Sergio Durigan Junior [this message]
2014-01-16 5:37 ` Joel Brobecker
2014-01-31 16:21 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m361pkbiwk.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).