From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Mark Kettenis <kettenis@gnu.org>
Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions
Date: Mon, 06 Jan 2014 15:34:00 -0000 [thread overview]
Message-ID: <m361px3yzr.fsf@redhat.com> (raw)
In-Reply-To: <20131230031112.GC6055@adacore.com> (Joel Brobecker's message of "Mon, 30 Dec 2013 07:11:12 +0400")
On Monday, December 30 2014, Joel Brobecker wrote:
>> As requested by Joel on:
>>
>> <https://sourceware.org/ml/gdb-patches/2013-12/msg00977.html>
>>
>> I am reposting this separate patch whose only purpose is to split
>> i386_stap_parse_special_token into smaller functions. I haven't
>> modified anything logical in the functions, i.e., there's still one
>> latent bug on i386_stap_parse_special_token_triplet now. I will soon
>> post a patch to fix this, and to also improve the readability of the two
>> new functions.
>>
>> I am also posting the output of "git diff -b" here.
>
> Thank you, Sergio. This patch is missing a ChangeLog :).
>
> FWIW, this patch looks good to me, and it is IMO a nice improvement
> over the current state. But i386-tdep.c is usually under Mark's
> responsibility, so let's give him a little bit of time to reply
> as well.
Ping.
--
Sergio
next prev parent reply other threads:[~2014-01-06 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 5:43 Sergio Durigan Junior
2013-12-30 3:11 ` Joel Brobecker
2013-12-30 5:38 ` Sergio Durigan Junior
2014-01-06 15:34 ` Sergio Durigan Junior [this message]
2014-01-11 1:52 ` Sergio Durigan Junior
2014-01-11 3:02 ` Joel Brobecker
2014-01-12 3:36 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m361px3yzr.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).