From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22145 invoked by alias); 6 Jan 2014 15:34:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22136 invoked by uid 89); 6 Jan 2014 15:34:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 15:34:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06FYqXI019382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Jan 2014 10:34:52 -0500 Received: from psique ([10.3.113.9]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s06FYng4003966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 6 Jan 2014 10:34:51 -0500 From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches , Mark Kettenis Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions References: <20131230031112.GC6055@adacore.com> X-URL: http://www.redhat.com Date: Mon, 06 Jan 2014 15:34:00 -0000 In-Reply-To: <20131230031112.GC6055@adacore.com> (Joel Brobecker's message of "Mon, 30 Dec 2013 07:11:12 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00056.txt.bz2 On Monday, December 30 2014, Joel Brobecker wrote: >> As requested by Joel on: >> >> >> >> I am reposting this separate patch whose only purpose is to split >> i386_stap_parse_special_token into smaller functions. I haven't >> modified anything logical in the functions, i.e., there's still one >> latent bug on i386_stap_parse_special_token_triplet now. I will soon >> post a patch to fix this, and to also improve the readability of the two >> new functions. >> >> I am also posting the output of "git diff -b" here. > > Thank you, Sergio. This patch is missing a ChangeLog :). > > FWIW, this patch looks good to me, and it is IMO a nice improvement > over the current state. But i386-tdep.c is usually under Mark's > responsibility, so let's give him a little bit of time to reply > as well. Ping. -- Sergio