From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20574 invoked by alias); 30 Dec 2013 05:38:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20563 invoked by uid 89); 30 Dec 2013 05:38:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Dec 2013 05:38:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBU5cXGp014957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Dec 2013 00:38:33 -0500 Received: from psique ([10.3.113.9]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBU5cUGC032415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 30 Dec 2013 00:38:32 -0500 From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches , Mark Kettenis Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions References: <20131230031112.GC6055@adacore.com> X-URL: http://www.redhat.com Date: Mon, 30 Dec 2013 05:38:00 -0000 In-Reply-To: <20131230031112.GC6055@adacore.com> (Joel Brobecker's message of "Mon, 30 Dec 2013 07:11:12 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00990.txt.bz2 On Monday, December 30 2014, Joel Brobecker wrote: > Thank you, Sergio. This patch is missing a ChangeLog :). Ops, forgot to post it, but it's here, I promise :-). > FWIW, this patch looks good to me, and it is IMO a nice improvement > over the current state. But i386-tdep.c is usually under Mark's > responsibility, so let's give him a little bit of time to reply > as well. Fair enough. Thanks! -- Sergio