From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23298 invoked by alias); 1 Oct 2013 00:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23285 invoked by uid 89); 1 Oct 2013 00:39:18 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 00:39:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r910dFX0007898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Sep 2013 20:39:15 -0400 Received: from psique (ovpn-113-41.phx2.redhat.com [10.3.113.41]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r910dAQv029489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 30 Sep 2013 20:39:13 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] make run References: X-URL: http://www.redhat.com Date: Tue, 01 Oct 2013 00:39:00 -0000 In-Reply-To: (Doug Evans's message of "Mon, 30 Sep 2013 15:29:11 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00000.txt.bz2 On Monday, September 30 2013, Doug Evans wrote: > Hi. > Since we can't agree on making gdb runnable from its build directory > (without having to manually specify --data-directory) > I plan to commit this patch (if there are no objections). Decisions from yesterday's chat? :-P > I plan to add an entry for it in the Hints section of the > wikified internals manual as well. > https://sourceware.org/gdb/wiki/InternalsManual It looks good to me (with the PHONY addition). Thanks for doing that! BTW, I think it would be good to explicitly mention the --data-directory option there too (if it's not mentioned yet, of course). > 2013-09-30 Doug Evans > > * Makefile.in (GDBFLAGS): New variable. > (run): New rule. > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.1270 > diff -u -p -r1.1270 Makefile.in > --- Makefile.in 25 Sep 2013 23:17:11 -0000 1.1270 > +++ Makefile.in 30 Sep 2013 22:17:58 -0000 > @@ -178,6 +178,9 @@ INTL_CFLAGS = @INCINTL@ > # Did the user give us a --with-gdb-datadir option? > GDB_DATADIR = @GDB_DATADIR@ > > +# Flags to pass to gdb when invoked with "make run". > +GDBFLAGS = > + > # Helper code from gnulib. > GNULIB_BUILDDIR = build-gnulib > LIBGNU = $(GNULIB_BUILDDIR)/import/libgnu.a > @@ -1339,6 +1342,9 @@ data-directory/Makefile: data-directory/ > CONFIG_LINKS= \ > $(SHELL) config.status > > +run: Makefile > + ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) > + > jit-reader.h: $(srcdir)/jit-reader.in > $(SHELL) config.status $@ -- Sergio