From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: add relative file name handling for linespecs
Date: Mon, 16 Jan 2012 19:01:00 -0000 [thread overview]
Message-ID: <m362gbpjus.fsf@fleche.redhat.com> (raw)
In-Reply-To: <E1RlDhG-0001RK-Pr@fencepost.gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2012 00:59:34 -0500")
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Tom> || (HAS_DRIVE_SPEC (filename) && len - search_len == 2)
Eli> Yes, I think it will.
I ended up going with:
|| (HAS_DRIVE_SPEC (filename)
&& STRIP_DRIVE_SPEC (filename) == &filename[len - search_len]));
... because STRIP_DRIVE_SPEC exists already and this lets us avoid
hard-coding a "2" into the code here.
Tom
next prev parent reply other threads:[~2012-01-16 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:32 Tom Tromey
2012-01-10 17:40 ` Eli Zaretskii
2012-01-11 21:52 ` Tom Tromey
2012-01-12 6:23 ` Eli Zaretskii
2012-01-16 19:01 ` Tom Tromey [this message]
2012-12-08 16:34 ` Jan Kratochvil
2012-12-08 18:33 ` Eli Zaretskii
2013-01-07 15:17 ` [testcase patch] New testcase: DOS drive letters in linespec [Re: RFC: add relative file name handling for linespecs] Jan Kratochvil
2013-01-17 20:42 ` [commit] " Jan Kratochvil
2012-01-11 9:03 ` RFC: add relative file name handling for linespecs Joel Brobecker
2012-01-16 19:29 ` Tom Tromey
2012-01-16 21:07 ` Tom Tromey
2012-01-19 15:39 ` Performance regression (12x): " Jan Kratochvil
2012-01-19 16:35 ` Tom Tromey
2012-01-31 20:18 ` Tom Tromey
2012-02-01 10:22 ` Joel Brobecker
2012-02-01 15:04 ` Tom Tromey
2012-02-01 15:07 ` Tom Tromey
2012-02-01 15:18 ` Joel Brobecker
2012-02-01 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362gbpjus.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).