From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 462 invoked by alias); 6 Oct 2010 22:25:48 -0000 Received: (qmail 450 invoked by uid 22791); 6 Oct 2010 22:25:47 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 22:25:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o96MPEA8024774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Oct 2010 18:25:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id o96MPDWK030484; Wed, 6 Oct 2010 18:25:14 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o96MPDwK013745; Wed, 6 Oct 2010 18:25:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CDAAB378893; Wed, 6 Oct 2010 16:25:12 -0600 (MDT) From: Tom Tromey To: Doug Evans Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: Python coding style References: Date: Wed, 06 Oct 2010 22:25:00 -0000 In-Reply-To: (Doug Evans's message of "Wed, 6 Oct 2010 14:20:53 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00092.txt.bz2 Doug> Can we, at least as a first pass, adopt this? Doug> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html It is ok with me. I read through it and I thought it seemed reasonable enough. Can you say how it compares to PEP 8? http://www.python.org/dev/peps/pep-0008/ They seemed basically compatible to me, but I only spent a few minutes with each. Since you are more familiar with it, would you mind doing a little extra review for changes to .py files for a while? Some of the rules are different enough from GNU C that it will take some getting used to; e.g., the hanging indentation rule. A couple specific exceptions: * We shouldn't use the #!/usr/bin/env thing * We should use FIXME instead of TODO, as the former is already gdb practice Phil> My deeply biased and very personal ideology her e is if how emacs Phil> handles it. The defaults are mostly ok. You'll need to set indent-tabs-mode to nil in these buffers (though even this happens automatically with the default settings). Tom