From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [vxworks 03/14] New module remote-wtx-utils
Date: Mon, 26 Apr 2010 18:55:00 -0000 [thread overview]
Message-ID: <m3633eniwf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1272210447-13895-4-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 25 Apr 2010 11:47:16 -0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> This module provides some general-purpose routines which might be
Joel> better off somewhere else... To be discussed individually for each
Joel> routine.
Joel> +have_dos_based_filesystem (void)
Joel> +is_regular_file (const char *name)
Joel> +skip_whitespaces (char *str)
Just "skip_whitespace" sounds more natural to me.
I think "whitespace" is commonly used for both singular and plural.
I think this particular function has been rewritten (inline) many times
throughout gdb...
Joel> +skip_until_character (char *str, char delimiter)
Joel> +skip_until_whitespace (char *str)
Joel> +skip_space_delimited_token (char *str)
Joel> +get_space_delimited_token (char *str, char **token)
I think all of these (including the others above) could be in util.c.
Joel> +void *load_shared_lib (char *lib_name)
Formatting.
Also, this should mention how errors are to be detected.
Joel> +void *get_symbol_from_shared_lib (void *handle, char *symbol)
Ditto.
Tom
next prev parent reply other threads:[~2010-04-26 18:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 15:47 Adding support for VxWorks target Joel Brobecker
2010-04-25 15:47 ` [vxworks 01/14] Some ada-lang/ada-tasks routines needed by the " Joel Brobecker
2010-04-25 15:48 ` [vxworks 10/14] Add new "wtx" target Joel Brobecker
2010-04-25 15:48 ` [vxworks 03/14] New module remote-wtx-utils Joel Brobecker
2010-04-26 18:55 ` Tom Tromey [this message]
2010-04-27 16:27 ` Joel Brobecker
2010-04-25 15:48 ` [vxworks 02/14] New command_post observer Joel Brobecker
2010-04-26 18:51 ` Tom Tromey
2010-04-27 14:22 ` Joel Brobecker
2010-04-27 17:16 ` Tom Tromey
2010-04-25 15:48 ` [vxworks 14/14] Configury and Makefile updates for VxWorks Joel Brobecker
2010-04-25 15:48 ` [vxworks 13/14] Add tdep files for x86 and powerpc Joel Brobecker
2010-04-25 20:45 ` Mark Kettenis
2010-04-26 16:41 ` Joel Brobecker
2010-04-25 15:48 ` [vxworks 11/14] WTX-TCL support module Joel Brobecker
2010-04-25 15:48 ` [vxworks 08/14] Partition support Joel Brobecker
2010-04-25 15:48 ` [vxworks 09/14] remote-wtx-hw / register fetch/store support Joel Brobecker
2010-04-25 15:56 ` [vxworks 06/14] VxWorks breakpoint-handling module Joel Brobecker
2010-04-25 15:56 ` [vxworks 05/14] Add options to control Vxworks related settings Joel Brobecker
2010-05-04 15:25 ` Joel Brobecker
2010-04-25 15:56 ` [vxworks 07/14] "multi-tasks-mode" support Joel Brobecker
2010-04-25 15:56 ` [vxworks 12/14] Add support for VxWorks 6 Joel Brobecker
2010-04-25 16:01 ` [vxworks 04/14] remote-wtxapi: The WTX API abstraction layer Joel Brobecker
2010-05-04 14:58 ` Adding support for VxWorks target Joel Brobecker
2010-05-04 15:43 ` Stan Shebs
2010-05-04 18:30 ` one big unit or several smaller units? (was: "Re: Adding support for VxWorks target") Joel Brobecker
2010-11-25 0:53 ` Adding support for VxWorks target Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3633eniwf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).