From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7768 invoked by alias); 26 Apr 2010 18:55:44 -0000 Received: (qmail 7759 invoked by uid 22791); 26 Apr 2010 18:55:43 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_WT,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 18:55:38 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QItFB0025074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Apr 2010 14:55:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QItE8j030971; Mon, 26 Apr 2010 14:55:15 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3QItDRJ012210; Mon, 26 Apr 2010 14:55:14 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A2DCE37820A; Mon, 26 Apr 2010 12:55:13 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [vxworks 03/14] New module remote-wtx-utils References: <1272210447-13895-1-git-send-email-brobecker@adacore.com> <1272210447-13895-4-git-send-email-brobecker@adacore.com> Reply-To: tromey@redhat.com Date: Mon, 26 Apr 2010 18:55:00 -0000 In-Reply-To: <1272210447-13895-4-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 25 Apr 2010 11:47:16 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00889.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This module provides some general-purpose routines which might be Joel> better off somewhere else... To be discussed individually for each Joel> routine. Joel> +have_dos_based_filesystem (void) Joel> +is_regular_file (const char *name) Joel> +skip_whitespaces (char *str) Just "skip_whitespace" sounds more natural to me. I think "whitespace" is commonly used for both singular and plural. I think this particular function has been rewritten (inline) many times throughout gdb... Joel> +skip_until_character (char *str, char delimiter) Joel> +skip_until_whitespace (char *str) Joel> +skip_space_delimited_token (char *str) Joel> +get_space_delimited_token (char *str, char **token) I think all of these (including the others above) could be in util.c. Joel> +void *load_shared_lib (char *lib_name) Formatting. Also, this should mention how errors are to be detected. Joel> +void *get_symbol_from_shared_lib (void *handle, char *symbol) Ditto. Tom