From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] inf-ptrace: Do not stop memory transfers after a single word
Date: Mon, 13 Mar 2017 19:50:00 -0000 [thread overview]
Message-ID: <m37f3tez1z.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <179457d2-c2aa-dd8d-d9c2-e1d3cca93930@redhat.com> (Pedro Alves's message of "Mon, 13 Mar 2017 19:39:29 +0000")
On Mon, Mar 13 2017, Pedro Alves wrote:
> On 03/10/2017 03:48 PM, Simon Marchi wrote:
>
>> I don't the idea behind that rule. I thought it was just for readability,
>> to make it clear that the variable is a pointer without having to refer to the
>> declaration. Perhaps some older timers could shed some light on that :).
>
> I don't know the original rationale, but I agree that nowadays the
> justification can only be in terms of readability. The same reason we
> do
> if (integer_that_is_not_a_boolean != 0)
> instead of
> if (integer_that_is_not_a_boolean)
> .
Right, it's a GDB-specific style rule. So who fixes the explanation on
the Wiki page? :-)
--
Andreas
next prev parent reply other threads:[~2017-03-13 19:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 16:01 [PATCH 0/3] PR gdb/21220: Fix quadratic runtime of memory writes into inferior on GNU/Linux Andreas Arnez
2017-03-06 16:01 ` [PATCH 1/3] inf-ptrace: Do not stop memory transfers after a single word Andreas Arnez
2017-03-08 19:10 ` Simon Marchi
2017-03-09 17:22 ` Andreas Arnez
2017-03-10 15:49 ` Simon Marchi
2017-03-13 19:39 ` Pedro Alves
2017-03-13 19:50 ` Andreas Arnez [this message]
2017-03-13 19:51 ` Pedro Alves
2017-03-14 15:12 ` Andreas Arnez
2017-03-14 15:23 ` Pedro Alves
2017-03-06 16:02 ` [PATCH 2/3] Test case for dump/restore of large array Andreas Arnez
2017-03-13 19:51 ` Pedro Alves
2017-03-06 16:03 ` [PATCH 3/3] linux-nat: Exploit /proc/<pid>/mem for writing Andreas Arnez
2017-03-13 20:05 ` Pedro Alves
2017-03-13 20:08 ` Pedro Alves
2017-03-14 11:23 ` Andreas Arnez
2017-03-14 9:54 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37f3tez1z.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).