public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: sami wagiaalla <swagiaal@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m  [Re: [patch] Defer symbol addition until construction is complete]
Date: Tue, 31 Aug 2010 18:37:00 -0000	[thread overview]
Message-ID: <m37hj6hbmd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100810074402.GA19162@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Tue, 10 Aug 2010 09:44:02 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> This patch has a cold regression. :-)
Jan> -PASS: gdb.cp/temargs.exp: test value of P in inner_m
Jan> +FAIL: gdb.cp/temargs.exp: test value of P in inner_m

I debugged this today.  I believe the problem is a g++ regression -- it
is not reporting all the template parameters.

I updated the relevant bug with my findings:

    http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41736

Sami> I looked into this some more. Here is the problem IIUC:

Sami> The template parameter P in this case is a member of the structure not
Sami> the function, but, from what I can tell, the template param patch
Sami> (240d54e9) supports storing and searching of template parameters only
Sami> if they are members of a function. If that is correct then this patch
Sami> just exposed that problem as opposed to case the regression.

Template parameters for types are put into the type's cplus_specific
structure.  See dwarf2read.c:read_structure_type.

Tom

      parent reply	other threads:[~2010-08-31 18:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 15:28 [patch] Defer symbol addition until construction is complete sami wagiaalla
2010-07-29 20:58 ` Tom Tromey
2010-08-09 18:38   ` sami wagiaalla
2010-08-09 19:55     ` Tom Tromey
2010-08-10  7:44     ` Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] Jan Kratochvil
2010-08-10 14:34       ` sami wagiaalla
2010-08-20 20:21         ` sami wagiaalla
2010-08-20 21:54           ` Tom Tromey
2010-08-31 15:18             ` sami wagiaalla
2010-08-31 18:37       ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37hj6hbmd.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).