From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25262 invoked by alias); 31 Aug 2010 18:37:38 -0000 Received: (qmail 25253 invoked by uid 22791); 31 Aug 2010 18:37:38 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 18:37:34 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7VIbWqC025655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 31 Aug 2010 14:37:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7VIbWDI011372; Tue, 31 Aug 2010 14:37:32 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7VIbVMt029067; Tue, 31 Aug 2010 14:37:31 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 10F8E3792BC; Tue, 31 Aug 2010 12:37:30 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: sami wagiaalla , gdb-patches@sourceware.org Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] References: <4C446F09.50107@redhat.com> <4C604B22.4060904@redhat.com> <20100810074402.GA19162@host1.dyn.jankratochvil.net> Date: Tue, 31 Aug 2010 18:37:00 -0000 In-Reply-To: <20100810074402.GA19162@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 10 Aug 2010 09:44:02 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00562.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> This patch has a cold regression. :-) Jan> -PASS: gdb.cp/temargs.exp: test value of P in inner_m Jan> +FAIL: gdb.cp/temargs.exp: test value of P in inner_m I debugged this today. I believe the problem is a g++ regression -- it is not reporting all the template parameters. I updated the relevant bug with my findings: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41736 Sami> I looked into this some more. Here is the problem IIUC: Sami> The template parameter P in this case is a member of the structure not Sami> the function, but, from what I can tell, the template param patch Sami> (240d54e9) supports storing and searching of template parameters only Sami> if they are members of a function. If that is correct then this patch Sami> just exposed that problem as opposed to case the regression. Template parameters for types are put into the type's cplus_specific structure. See dwarf2read.c:read_structure_type. Tom