From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74591-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24091 invoked by alias); 28 Jul 2010 16:09:09 -0000
Received: (qmail 24075 invoked by uid 22791); 28 Jul 2010 16:09:07 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Jul 2010 16:08:58 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6SG8n8V016318	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 28 Jul 2010 12:08:49 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6SG8miH016663;	Wed, 28 Jul 2010 12:08:48 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6SG8ll9021638;	Wed, 28 Jul 2010 12:08:48 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 66F8C378213; Wed, 28 Jul 2010 10:08:46 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: Improve 'this' detection
References: <201007272217.14220.pedro@codesourcery.com>
Date: Wed, 28 Jul 2010 16:09:00 -0000
In-Reply-To: <201007272217.14220.pedro@codesourcery.com> (Pedro Alves's	message of "Tue, 27 Jul 2010 22:17:13 +0100")
Message-ID: <m37hkfoagi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00482.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> This patch of Daniel's improves THIS detection in C++
Pedro> method's parameters.  The user visible change is that GDB now
Pedro> presents the `this' parameter type const qualified.

Pedro> The patch looked pretty reasonable to me.

Pedro> Comments?

Looks reasonable to me too.

Pedro> +		 DWARF version 3 added DW_AT_object_pointer, which GCC
Pedro> +		 4.5 does not yet generate.  */

Do we want GCC to emit this?  If so, I can file a bug.

Tom