From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Doug Evans <dje@google.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 4/7] AVR support
Date: Wed, 07 Aug 2013 21:03:00 -0000 [thread overview]
Message-ID: <m38v0d1aer.fsf@redhat.com> (raw)
In-Reply-To: <CADPb22Q9-AaJ=WFK4qXaQdzEFQ3_EHfngLJaWZ8C9Cue=yptyA@mail.gmail.com> (Doug Evans's message of "Sat, 27 Jul 2013 10:10:47 -0700")
On Saturday, July 27 2013, Doug Evans wrote:
> Hi. Just a nit.
>
> On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>> Support for the AVR architecture. More of the same. Defining an enum
>> containing the differences between Linux kernel generic and AVR signals,
>> and treat them on avr_linux_gdb_signal_{to,from}_target. In this case,
>> the only difference is the SIGRTMAX.
>>
>> 2013-07-26 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * avr-tdep.c: Define enum with differences between Linux kernel
>> and AVR signals.
>> (avr_linux_gdb_signal_from_target): New function.
>> (avr_linux_gdb_signal_to_target): Likewise.
>> (avr_gdbarch_init): Set gdbarch_gdb_signal_{to,from}_target to
>> the functions mentioned above.
>> [...]
>> + /* GDB_SIGNAL_REALTIME_33 to _63 are continuous.
>> +
>
> Nit: Either delete this blank line or move it to after the comment.
Fixed, thanks.
--
Sergio
next prev parent reply other threads:[~2013-08-07 21:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:13 [PATCH 0/7] Implement gdbarch_gdb_signal_{to,from}_target Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 6/7] Xtensa support Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 7/7] MIPS support Sergio Durigan Junior
2013-07-27 17:22 ` Doug Evans
2013-08-07 21:02 ` Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 5/7] SPARC support Sergio Durigan Junior
2013-07-27 17:13 ` Doug Evans
2013-08-07 21:03 ` Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 2/7] Linux kernel generic support Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 4/7] AVR support Sergio Durigan Junior
2013-07-27 17:10 ` Doug Evans
2013-08-07 21:03 ` Sergio Durigan Junior [this message]
2013-07-26 20:13 ` [PATCH 1/7] Implement the gdbarch.{sh,c,h} bits Sergio Durigan Junior
2013-07-26 20:13 ` [PATCH 3/7] Alpha support Sergio Durigan Junior
2013-07-29 16:44 ` Pedro Alves
2013-08-07 21:09 ` Sergio Durigan Junior
2013-08-08 15:44 ` Pedro Alves
2013-07-27 17:57 ` [PATCH 0/7] Implement gdbarch_gdb_signal_{to,from}_target Doug Evans
2013-08-07 20:54 ` Sergio Durigan Junior
2013-07-29 16:43 ` Pedro Alves
2013-08-09 16:56 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38v0d1aer.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).