From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32377 invoked by alias); 6 Feb 2012 21:45:26 -0000 Received: (qmail 32356 invoked by uid 22791); 6 Feb 2012 21:45:24 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 21:45:10 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q16Lj93T023889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Feb 2012 16:45:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q16Lj8dk028341; Mon, 6 Feb 2012 16:45:09 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q16Lj6nT030133; Mon, 6 Feb 2012 16:45:06 -0500 From: Tom Tromey To: xgsa Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: RTTI type improvement for References: <4ED92C05.9080803@yandex.ru> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> Date: Mon, 06 Feb 2012 21:45:00 -0000 In-Reply-To: <4F07177C.5080201@yandex.ru> (xgsa@yandex.ru's message of "Fri, 06 Jan 2012 17:47:08 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00070.txt.bz2 >>>>> "Anton" == xgsa writes: Anton> The second part requires this one to be applied, so I'll provide Anton> it after commit. It is fine to pipeline patches. Often it is even preferable to do this, but it depends on how independent the individual patches actually are. Anton> +struct value * Anton> +readjust_indirect_value_type (struct value *value, struct type *enc_type, Anton> + struct type *original_type, Anton> + struct value *original_value) I wonder if there is a cleaner way to do this same thing. Say, a kind of value constructor as opposed to something that rewrites an existing value? If not, that is fine. Anton> +extern struct value * Anton> +readjust_indirect_value_type (struct value *value, struct type *enc_type, Anton> + struct type *original_type, Anton> + struct value *original_value); If you're going to split the first line that way, I think you should indent the subsequent lines by 4 or 5 spaces (not sure what the standard is, if there is one). Probably better to split before the open paren though (and still indent; there are examples of this elsewhere). Tom